Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add require_alias event log when indexing documents #130332

Merged
merged 3 commits into from
Apr 18, 2022

Conversation

mikecote
Copy link
Contributor

Fixes #93971

To verify

  1. Comment out the alias section when creating the initial event log index (https://github.com/elastic/kibana/blob/main/x-pack/plugins/event_log/server/es/init.ts#L208-L213)
  2. Start Kibana and notice the no such index [.kibana-event-log-8.3.0] and [require_alias] request flag is [true] and [.kibana-event-log-8.3.0] is not an alias error logged when trying to log the startup event doc.

@mikecote mikecote added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:EventLog v8.3.0 labels Apr 14, 2022
@mikecote mikecote self-assigned this Apr 14, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mikecote

@mikecote mikecote marked this pull request as ready for review April 18, 2022 15:00
@mikecote mikecote requested a review from a team as a code owner April 18, 2022 15:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Verified that I see an error indexing when no alias is present.

@mikecote mikecote merged commit c64ebc2 into elastic:main Apr 18, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 18, 2022
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
* Add require_alias to index event log documents

* Fix jest test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:EventLog release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[event log] use require_alias when indexing event log documents
5 participants