[Lens] Improve Toolbar Responsiveness #130175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove-toolbar-responsiveness
MichaelMarcialis
added
Team:Visualizations
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
drewdaemon
reviewed
Apr 14, 2022
.../plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/warnings_popover.scss
Show resolved
Hide resolved
...s/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel_wrapper.scss
Show resolved
Hide resolved
stratoula
approved these changes
Apr 14, 2022
kibanamachine
pushed a commit
that referenced
this pull request
Apr 14, 2022
* reduce flex gutters, fix wrapping behavior, etc. * hide text at medium and lower bps for better fit * adjust full screen toolbar styles * expand hiding of button text to large bp * adjust flex item alignment and wrapping (cherry picked from commit d5d798f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 14, 2022
* reduce flex gutters, fix wrapping behavior, etc. * hide text at medium and lower bps for better fit * adjust full screen toolbar styles * expand hiding of button text to large bp * adjust flex item alignment and wrapping (cherry picked from commit d5d798f) Co-authored-by: Michael Marcialis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issues that cause the Lens toolbar to appear broken/odd at smaller viewport sizes. Notable changes include:
Closes issue #128428.
Screenshots of the changes at various viewport sizes
Checklist
Delete any items that are not applicable to this PR.