[Session View] [8.2] beta label added to sessions tabs in timeline #129965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitodrummer
added
auto-backport
mitodrummer
requested review from
michaelolo24,
YulNaumenko and
kqualters-elastic
mitodrummer
added
the
release_note:skip
YulNaumenko
reviewed
Apr 12, 2022
| @@ -45,6 +47,7 @@ const TabNavigationItemComponent = ({ | |||
| isSelected={isSelected} | |||
| href={appHref} | |||
| onClick={handleClick} | |||
| append={isBeta && <EuiBetaBadge label={BETA} size="s" />} | |||
There was a problem hiding this comment.
Could you please add a unit test where make sure that the beta badge was added only if isBeta property is true?
added 4 commits
April 11, 2022 19:05
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
janmonschke
approved these changes
Apr 12, 2022
michaelolo24
approved these changes
Apr 12, 2022
kibanamachine
pushed a commit
that referenced
this pull request
Apr 12, 2022
…129965) * beta label added to sessions tabs in timeline * added test for isBeta * added test for isBeta * test revised Co-authored-by: mitodrummer <[email protected]> (cherry picked from commit bced9d2)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 12, 2022
…129965) (#130015) * beta label added to sessions tabs in timeline * added test for isBeta * added test for isBeta * test revised Co-authored-by: mitodrummer <[email protected]> (cherry picked from commit bced9d2) Co-authored-by: Karl Godard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #129923
Adds a EuiBetaBadge to the new sessions tab in hosts page and the Session View tab in timeline.