[Session view] Search will now only search through verbose stuff if verbose mode is on. #129959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitodrummer
added
auto-backport
mitodrummer
added
the
release_note:skip
…a into search_verbosemode_fix
…lso fixed ordering of children and search results.
…eaks to scrollIntoView
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
that referenced
this pull request
Apr 12, 2022
…erbose mode is on. (#129959) * session view search will now only search through verbose stuff if verbose mode is on. * lint fix * revised approach to auto expand when searching. * any process with alerts now is auto expanded, regardless of jumpTo * removed hacky selectionArea code (it was a premature optimization). also fixed ordering of children and search results. * another couple fixes. duplicated events in ProcessImpl, as well as tweaks to scrollIntoView * fix to nested jumpTo not working on initial load Co-authored-by: mitodrummer <[email protected]> (cherry picked from commit d1e3ce2)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 12, 2022
…erbose mode is on. (#129959) (#129979) * session view search will now only search through verbose stuff if verbose mode is on. * lint fix * revised approach to auto expand when searching. * any process with alerts now is auto expanded, regardless of jumpTo * removed hacky selectionArea code (it was a premature optimization). also fixed ordering of children and search results. * another couple fixes. duplicated events in ProcessImpl, as well as tweaks to scrollIntoView * fix to nested jumpTo not working on initial load Co-authored-by: mitodrummer <[email protected]> (cherry picked from commit d1e3ce2) Co-authored-by: Karl Godard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the following issues:
#129535
#129536
https://www.loom.com/share/6eb3692fc85a4ad3bb74b398d6c7c08e
Checklist
Delete any items that are not applicable to this PR.