Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Fix typo in logstash pipeline instructions #129939

Merged
merged 2 commits into from
Apr 11, 2022
Merged

[Fleet] Fix typo in logstash pipeline instructions #129939

merged 2 commits into from
Apr 11, 2022

Conversation

nchaulet
Copy link
Member

Summary

Fix the logstash pipeline instructions to replace an invalid comment

cacert: should be cacert =>

Also I updated some of the placeholder to be more clear of what is expected in that config.

@nchaulet nchaulet added backport:skip This commit does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v8.3.0 labels Apr 11, 2022
@nchaulet nchaulet requested a review from kpollich April 11, 2022 19:31
@nchaulet nchaulet self-assigned this Apr 11, 2022
@nchaulet nchaulet requested a review from a team as a code owner April 11, 2022 19:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes and removed backport:skip This commit does not require backporting labels Apr 11, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 692.7KB 692.7KB +15.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 3c805d2 into elastic:main Apr 11, 2022
@nchaulet nchaulet deleted the fix-typo-logstash-instructions branch April 11, 2022 21:03
kibanamachine pushed a commit that referenced this pull request Apr 11, 2022
@nchaulet
[Fleet] Fix typo in logstash pipeline instructions (#129939)
f76ec01 
(cherry picked from commit 3c805d2)
@kibanamachine kibanamachine mentioned this pull request Apr 11, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 11, 2022
@kibanamachine @nchaulet
[Fleet] Fix typo in logstash pipeline instructions (#129939) (#129953)
3a9917d 
(cherry picked from commit 3c805d2)

Co-authored-by: Nicolas Chaulet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich approved these changes

Assignees

@nchaulet nchaulet

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nchaulet @elasticmachine @kibana-ci @kibanamachine @kpollich