Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Remove additional Visualization labels #129920

Merged
merged 2 commits into from
Apr 11, 2022
Merged

[SecuritySolution] Remove additional Visualization labels #129920

merged 2 commits into from
Apr 11, 2022

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Apr 11, 2022 •
edited
Loading

Summary

Some KPIs have additional label when opened in Lens, removing them to make them consistence.
Fixes: #128597

Steps to Reproduce:

  1. Navigate to Network page
  2. Open DNS KPI, Unique private IPs - source, and Unique private IPs - destination (Not bar charts or area charts) in Lens
  3. It should have no label under the number

Example
Before:
Screenshot 2022-04-12 at 00 53 27
After:
Screenshot 2022-04-12 at 00 53 52

@angorayc angorayc requested a review from a team as a code owner April 11, 2022 17:20
@angorayc angorayc added bug Fixes for quality problems that affect the customer experience Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore labels Apr 11, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@angorayc angorayc added v8.2.0 release_note:skip Skip the PR/issue when compiling release notes labels Apr 11, 2022
@angorayc angorayc changed the title [SecuritySolution] Update Visualization labels [SecuritySolution] Remove additional Visualization labels Apr 11, 2022
@angorayc angorayc added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 11, 2022
@angorayc angorayc enabled auto-merge (squash) April 11, 2022 17:35
YulNaumenko
YulNaumenko approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angorayc angorayc merged commit cbd58bc into elastic:main Apr 11, 2022
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] OSS CI Group #11 / visualize app visualize ciGroup11 visual builder Time Series basics Clicking on the chart should create a filter for series with multiple split by terms fields one of which has formatting

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.8MB 4.8MB -19.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine mentioned this pull request Apr 11, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Apr 11, 2022
@angorayc
[SecuritySolution] Remove additional Visualization labels (#129920)
ded0272 
* remove metric labels

* remove metric labels

(cherry picked from commit cbd58bc)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 11, 2022
@kibanamachine @angorayc
[SecuritySolution] Remove additional Visualization labels (#129920) (#…
d23f42b 
…129950)

* remove metric labels

* remove metric labels

(cherry picked from commit cbd58bc)

Co-authored-by: Angela Chuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamster10 jamster10 jamster10 approved these changes

@YulNaumenko YulNaumenko YulNaumenko approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.2.0
Projects
None yet
Milestone
No milestone
6 participants
@angorayc @elasticmachine @kibana-ci @kibanamachine @jamster10 @YulNaumenko