Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] fixed enrollment token modal for managed policy #129870

Merged
merged 1 commit into from
Apr 12, 2022
Merged

[Fleet] fixed enrollment token modal for managed policy #129870

merged 1 commit into from
Apr 12, 2022

Conversation

juliaElastic
Copy link
Contributor

Summary

Fixes #128599 for managed policies

To verify:

  • create a managed policy in preconfig
  • go to Enrollment tokens / Create enrollment token
  • verify that Create button is disabled

image

image

@juliaElastic juliaElastic added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v8.3.0 labels Apr 11, 2022
@juliaElastic juliaElastic self-assigned this Apr 11, 2022
@juliaElastic juliaElastic requested a review from a team as a code owner April 11, 2022 07:58
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Apr 11, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 684.3KB 684.3KB +3.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

nchaulet
nchaulet approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@juliaElastic juliaElastic merged commit 485f2d1 into elastic:main Apr 12, 2022
@juliaElastic juliaElastic deleted the fix-new-enrollment-token-managed branch April 12, 2022 06:36
kibanamachine pushed a commit that referenced this pull request Apr 12, 2022
@juliaElastic
fixed enrollment token modal for managed policy (#129870)
f16186b 
(cherry picked from commit 485f2d1)
@kibanamachine kibanamachine mentioned this pull request Apr 12, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 12, 2022
@kibanamachine @juliaElastic
fixed enrollment token modal for managed policy (#129870) (#129975)
04370b9 
(cherry picked from commit 485f2d1)

Co-authored-by: Julia Bardi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

Assignees

@juliaElastic juliaElastic

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet]: Able to create enrollment tokens without selecting any policy.
5 participants
@juliaElastic @elasticmachine @kibana-ci @kibanamachine @nchaulet