-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jump to nested entity_id fixed. verbose mode now defaults to OFF #129783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build SucceededTest Failures
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
zizhouW
approved these changes
Apr 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
mitodrummer
added a commit
to mitodrummer/kibana
that referenced
this pull request
Apr 9, 2022
…stic#129783) * jump to nested entity_id fixed. verbose mode now defaults to OFF * dropping exit code UX Co-authored-by: mitodrummer <[email protected]> (cherry picked from commit f218580)
mitodrummer
added a commit
that referenced
this pull request
Apr 9, 2022
…9783) (#129855) * jump to nested entity_id fixed. verbose mode now defaults to OFF * dropping exit code UX Co-authored-by: mitodrummer <[email protected]> (cherry picked from commit f218580)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
bug
Fixes for quality problems that affect the customer experience
release_note:skip
Skip the PR/issue when compiling release notes
v8.2.0
v8.3.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue where nested processes could not be "jumped to".
Also have updated verbose mode to default to OFF.
Also removes exit code from process_tree_node (was not part of original design, we will revisit this in a future release)
https://www.loom.com/share/85bccefef9884270bef4b6b5bf5ed6e2