Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jump to nested entity_id fixed. verbose mode now defaults to OFF #129783

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

mitodrummer
Copy link
Contributor

@mitodrummer mitodrummer commented Apr 7, 2022

Summary

Fixes issue where nested processes could not be "jumped to".

Also have updated verbose mode to default to OFF.

Also removes exit code from process_tree_node (was not part of original design, we will revisit this in a future release)

https://www.loom.com/share/85bccefef9884270bef4b6b5bf5ed6e2

@mitodrummer mitodrummer added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v8.3.0 labels Apr 7, 2022
@mitodrummer mitodrummer requested a review from a team April 7, 2022 18:11
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Test Failures

  • [job] [logs] OSS CI Group #11 / visualize app visualize ciGroup11 visual builder Time Series basics Clicking on the chart should create a filter for series with multiple split by terms fields one of which has formatting

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
sessionView 60.0KB 59.9KB -80.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mitodrummer mitodrummer enabled auto-merge (squash) April 7, 2022 20:31
Copy link

@zizhouW zizhouW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitodrummer mitodrummer merged commit f218580 into elastic:main Apr 7, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.2 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.2:
- [Session View] Display Option bug fix (#129262)

Manual backport

To create the backport manually run:

node scripts/backport --pr 129783

Questions ?

Please refer to the Backport tool documentation

mitodrummer added a commit to mitodrummer/kibana that referenced this pull request Apr 9, 2022
…stic#129783)

* jump to nested entity_id fixed. verbose mode now defaults to OFF

* dropping exit code UX

Co-authored-by: mitodrummer <[email protected]>
(cherry picked from commit f218580)
mitodrummer added a commit that referenced this pull request Apr 9, 2022
…9783) (#129855)

* jump to nested entity_id fixed. verbose mode now defaults to OFF

* dropping exit code UX

Co-authored-by: mitodrummer <[email protected]>
(cherry picked from commit f218580)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v8.2.0 v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alerted child processes do not get auto expanded when jumping to alert
4 participants