[Discover] account for hidden time column in default sort #129659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewdaemon
changed the title
drewdaemon
added
Feature:Discover
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
kertal
reviewed
Apr 7, 2022
src/plugins/discover/public/components/doc_table/lib/get_default_sort.ts
Outdated
Show resolved
Hide resolved
kertal
reviewed
Apr 7, 2022
src/plugins/discover/public/components/doc_table/lib/get_default_sort.ts
Outdated
Show resolved
Hide resolved
kertal
reviewed
Apr 7, 2022
Comment on lines
+216
to
+221
| private getDefaultSort(dataView?: DataView) { | ||
| const defaultSortOrder = this.services.uiSettings.get(SORT_DEFAULT_ORDER_SETTING, 'desc'); | ||
| const hidingTimeColumn = this.services.uiSettings.get(DOC_HIDE_TIME_COLUMN_SETTING, false); | ||
| return getDefaultSort(dataView, defaultSortOrder, hidingTimeColumn); | ||
| } | ||
|
|
Comment on lines
+216
to
+221
| private getDefaultSort(dataView?: DataView) { | ||
| const defaultSortOrder = this.services.uiSettings.get(SORT_DEFAULT_ORDER_SETTING, 'desc'); | ||
| const hidingTimeColumn = this.services.uiSettings.get(DOC_HIDE_TIME_COLUMN_SETTING, false); | ||
| return getDefaultSort(dataView, defaultSortOrder, hidingTimeColumn); | ||
| } | ||
|
|
There was a problem hiding this comment.
well, seems I clicked to often, or GitHub has issues?
kertal
approved these changes
Apr 7, 2022
There was a problem hiding this comment.
Code LGTM, this fixes the linked issue, thx a lot 👍 Tested with Firefox, Chrome, Safari, works as expected.
One think worth a follow up. When you have an existing saved search with sorting by time field in the saved object, you can't unsort when not using the Document explorer.
…lt_sort.ts Co-authored-by: Matthias Wilhelm <[email protected]>
💛 Build succeeded, but was flakyTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
that referenced
this pull request
Apr 7, 2022
(cherry picked from commit ae68c1c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 7, 2022
…129788) (cherry picked from commit ae68c1c) Co-authored-by: Andrew Tate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #121263
The time column is no longer assigned as the default sort when it is hidden via advanced settings.
Checklist