Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Add more scaffolding for Content plugin #129533

Merged
merged 11 commits into from
Apr 6, 2022
Merged

[Enterprise Search] Add more scaffolding for Content plugin #129533

merged 11 commits into from
Apr 6, 2022

Conversation

scottybollinger
Copy link
Contributor

@scottybollinger scottybollinger commented Apr 5, 2022 •
edited
Loading

closes https://github.com/elastic/enterprise-search-team/issues/1724

Summary

More progress on the scaffolding for the Enterprise Search Content plugin. Specifically, this PR:

  • Removes the Settings view in favor of the 2 granular Connector settings and Web crawler settings views.
  • Wires up the New index view with the different section placeholders for the 5 ingestion methods.
  • Adds the Overview link back to the main navigation, per Product. (6a3cd96)
  • image
walkthrough.mp4

Checklist

@scottybollinger
Rename Settings to Connector settings
92639c5
@scottybollinger
Add page stub and nav item for Web crawler settings
87dea4c
@scottybollinger
Add EuiButtonIconTo React Router helper
b41f502
@scottybollinger
Refactor to use mock data
e89f56f 
- Also extracts and renames SearchIndex type
- Use correct document_count property
@scottybollinger
Refator to use correct indexSlug
c086ca9 
Also implements the new EuiButtonIconTo helper
@scottybollinger
Wire up link to new index view
f22f10f
@scottybollinger
Stub out different panles and component for new index view
0a7ac50 
Based on Davey’s initial static work found here:
https://github.com/daveyholler/floating-hippo

Left a bunch of TODOs in the code and could use some further refactoring.
@scottybollinger
Add “Overiew” to main Kibana navigation
6a3cd96 
This was removed here:

elastic#114018

…but Product has requested that it be put back so it is visibe.
@scottybollinger scottybollinger added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.3.0 labels Apr 5, 2022
@scottybollinger scottybollinger changed the title [Enterprise Search] Add mroe scaffolding for Content plugin [Enterprise Search] Add more scaffolding for Content plugin Apr 5, 2022
@scottybollinger scottybollinger force-pushed the b/scaffolding-updates branch from 9ea60d3 to 4227a95 Compare April 6, 2022 13:39
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 1449 1462 +13

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.5MB 1.5MB +12.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 318.7KB 318.7KB -19.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@scottybollinger scottybollinger marked this pull request as ready for review April 6, 2022 16:53
@scottybollinger scottybollinger requested a review from a team April 6, 2022 16:53
@scottybollinger scottybollinger requested a review from a team as a code owner April 6, 2022 16:53
efegurkan
efegurkan approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@efegurkan efegurkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That took a while to review, :D looks good

@scottybollinger scottybollinger enabled auto-merge (squash) April 6, 2022 18:27
TinaHeiligers
TinaHeiligers approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, one less hard-coded item 😄
chrome changes LGTM

@scottybollinger scottybollinger merged commit ff753e2 into elastic:main Apr 6, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efegurkan efegurkan efegurkan approved these changes

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@scottybollinger @kibana-ci @efegurkan @TinaHeiligers @kibanamachine