Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitor management] Fix test now mode issues #129501

Merged
merged 6 commits into from
Apr 7, 2022
Merged

[Monitor management] Fix test now mode issues #129501

merged 6 commits into from
Apr 7, 2022

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Apr 5, 2022 •
edited
Loading

Summary

Fixes elastic/uptime#457

shows the error in case journey fails to start

Fixes the unnecessary loading for skipped step screenshot

After:

image

Before

image

@shahzad31 shahzad31 marked this pull request as ready for review April 7, 2022 12:01
@shahzad31 shahzad31 requested a review from a team as a code owner April 7, 2022 12:01
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.2.0 v8.3.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 7, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 776.4KB 777.1KB +711.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

awahab07
awahab07 approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Skipped step is not reloaded over and over anymore.
  • In case of syntax error in the journey, error log is displayed instead of steps details.

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Apr 7, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 merged commit 4f34f07 into elastic:main Apr 7, 2022
@shahzad31 shahzad31 deleted the fix-test-now-mode-issues branch April 7, 2022 14:09
@kibanamachine kibanamachine mentioned this pull request Apr 7, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Apr 7, 2022
@shahzad31
[Monitor management] Fix test now mode issues (#129501)
aee715c 
(cherry picked from commit 4f34f07)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 7, 2022
@kibanamachine @shahzad31
[Monitor management] Fix test now mode issues (#129501) (#129750)
b7538d8 
(cherry picked from commit 4f34f07)

Co-authored-by: Shahzad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awahab07 awahab07 awahab07 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.2.0 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with Test Now in Monitor Management UI
5 participants
@shahzad31 @kibana-ci @elasticmachine @kibanamachine @awahab07