Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitor management] Update to use new add monitor endpoint #129447

Merged
merged 10 commits into from
Apr 6, 2022
Merged

[Monitor management] Update to use new add monitor endpoint #129447

merged 10 commits into from
Apr 6, 2022

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Apr 5, 2022 •
edited
Loading

Summary

Fixes elastic/uptime#469

When user is adding a new monitor, service will return an error if public beta limit is reached and it will be displayed

Use PUT method for syncing monitors
Use POST method for adding a monitor

image

@shahzad31 shahzad31 marked this pull request as ready for review April 5, 2022 12:05
@shahzad31 shahzad31 requested a review from a team as a code owner April 5, 2022 12:05
@shahzad31 shahzad31 self-assigned this Apr 5, 2022
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.2.0 v8.3.0 labels Apr 5, 2022
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Apr 5, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #10 / maps app geo file upload geojson file upload should add as document layer

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 776.1KB 776.4KB +261.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

awahab07
awahab07 approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I also handled a few nullability cases.

@shahzad31 shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 6, 2022
@shahzad31 shahzad31 merged commit 39cf5d5 into elastic:main Apr 6, 2022
@shahzad31 shahzad31 deleted the add-monitor-endpoint branch April 6, 2022 11:43
@kibanamachine kibanamachine mentioned this pull request Apr 6, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit that referenced this pull request Apr 6, 2022
@shahzad31
[Monitor management] Update to use new add monitor endpoint (#129447)
a3973a8 
Co-authored-by: Abdul Zahid <[email protected]>
(cherry picked from commit 39cf5d5)
kibanamachine added a commit that referenced this pull request Apr 6, 2022
@kibanamachine @shahzad31
[Monitor management] Update to use new add monitor endpoint (#129447) (…
092b6ae 
…#129582)

Co-authored-by: Abdul Zahid <[email protected]>
(cherry picked from commit 39cf5d5)

Co-authored-by: Shahzad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awahab07 awahab07 awahab07 approved these changes

Assignees

@shahzad31 shahzad31

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.2.0 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use a different method for adding a monitor
5 participants
@shahzad31 @elasticmachine @kibana-ci @kibanamachine @awahab07