Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes references to kibana.yml settings from tooltip #129439

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Removes references to kibana.yml settings from tooltip #129439

merged 1 commit into from
Apr 5, 2022

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Apr 5, 2022 •
edited
Loading

Summary

This PR modifies a tooltip in rule_form.tsx which mentions two settings from kibana.yml. Tooltips rarely reference low-level technical info. It makes the tooltip long and harder to read.

@szabosteve szabosteve added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.2.0 ui-copy Review of UI copy with docs team is recommended v8.3.0 labels Apr 5, 2022
@szabosteve szabosteve requested a review from lcawl April 5, 2022 06:20
@szabosteve szabosteve requested a review from a team as a code owner April 5, 2022 06:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@szabosteve szabosteve requested a review from a team April 5, 2022 06:21
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 697.7KB 697.5KB -210.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@szabosteve szabosteve requested a review from peteharverson April 5, 2022 08:48
sophiec20
sophiec20 approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@sophiec20 sophiec20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peteharverson
peteharverson approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szabosteve szabosteve merged commit abc2dd0 into elastic:main Apr 5, 2022
@szabosteve szabosteve deleted the fix.tooltip.alert branch April 5, 2022 12:23
@szabosteve szabosteve mentioned this pull request Apr 5, 2022
Merged
szabosteve added a commit to szabosteve/kibana that referenced this pull request Apr 5, 2022
@szabosteve
Removes references to kibana.yml settings from tooltip. (elastic#129439)
b6b0167
szabosteve added a commit that referenced this pull request Apr 5, 2022
@szabosteve
Removes references to kibana.yml settings from tooltip. (#129439) (#1…
fd20294 
…29454)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophiec20 sophiec20 sophiec20 approved these changes

@peteharverson peteharverson peteharverson approved these changes

@lcawl lcawl Awaiting requested review from lcawl

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) ui-copy Review of UI copy with docs team is recommended v8.2.0 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@szabosteve @elasticmachine @kibana-ci @sophiec20 @peteharverson