[SharedUX] Fix warning in solution_nav test #129322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majagrubic
added
Team:SharedUX
sebelga
reviewed
Apr 4, 2022
| @@ -14,6 +14,9 @@ jest.mock('@elastic/eui', () => ({ | |||
| useIsWithinBreakpoints: (args: string[]) => { | |||
| return args[0] === 'xs'; | |||
| }, | |||
| EuiSideNav: function Component() { | |||
| // no-op | |||
There was a problem hiding this comment.
Shouldn't a functional component always return? It seems that for consistency we should return null. WDYT?
There was a problem hiding this comment.
I think when returning null we'd explicitly want it to be null. By "no-op" we're saying "I don't care what this returns".
sebelga
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the following warning in the
solution_navtest.The problem was that
@elastic/euilibrary is mocked, but only one method was actually implemented. The PR adds a mock implementation ofEuiSideNavas well.Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)- [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)- [ ] This was checked for cross-browser compatibilityFor maintainers