-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Fix auto session-renewal on non-timebased data views #129313
Conversation
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks great and works as expected. Approved.
When checking it though, I noticed that we can set auto refresh in the dashboard and then go to one of the Lens panels that have no time based data view, the Lens editor keeps refreshing. There's no way to turn it off as a time picker is not visible. Do you think it's an issue worth reporting or we are ok with this behavior?
This bug has been also issued for Discover #102132. |
@stratoula That's a separate issue, this one is not about auto-refresh in the sense of "every n seconds", but about the refetching of data on user-initiated change if too much time passed since data was last fetched (2% of the length of the current time range). Still agree about the "autoRefreshOnly" component - this is a valid use case. |
@flash1293 I was referring to Marta's comment. If I get it correctly she refers to the timepicker Refresh every x minutes. Have I misunderstood the comment? |
no no, you're right - I think Joe was referring to the PR, and you to my comment. That's why I shouldn't start discussion about different problem inside the other problem 😅 |
Ah, sorry! |
Oh sorry, no comment on the PR, it works fine :D |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit f3f3b1a)
…#129567) (cherry picked from commit f3f3b1a) Co-authored-by: Joe Reuter <[email protected]>
Fixes #129028
This PR makes sure the session is not auto-refreshed due to time lag if the current data view isn't bound to the time picker.
Cases that should work:
No time field / no date histogram
No time field / date histogram
No time field / unbound date histogram
Time field