Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Return keyboard focus to "Documents selected" button after closing the popover menu #129305

Closed
wants to merge 1 commit into from
Closed

[Discover] Return keyboard focus to "Documents selected" button after closing the popover menu #129305

wants to merge 1 commit into from

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Apr 4, 2022

Closes #121347

Summary

Navigating away from "N documents selected" popover with ESC key will now return focus back to the button.
Apr-04-2022 11-42-54

Checklist

  • Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
  • Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)

@jughosta jughosta added Feature:Discover Discover Application release_note:fix backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. :DataDiscovery/fix-it-week v8.3.0 labels Apr 4, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 400.4KB 400.5KB +124.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jughosta jughosta mentioned this pull request Apr 4, 2022
Closed
@jughosta jughosta closed this Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application release_note:fix Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discover][KEYBOARD]: Documents selected button should receive keyboard focus when the popover menu is closed
2 participants
@jughosta @kibana-ci