[Session View] jumpToEntityId / investigatedAlertId behavior fixed. #129275

mitodrummer · 2022-04-02T07:29:06Z

Summary

Kinks have been worked out around jumpToEntityId (bi-directional pagination) functionality. I've also added the missing plumbing to make use of it in security_solution plugin when launching session view from timeline component.

QA

Loading session viewer from the Hosts -> events tab should jump to and select the event from the table
Loading session viewer from the Alerts page should mark the alert as the "investigated alert" and jump to it's position
Jump to alerted process button (in alert details tab) should work for very large sessions, as it will make use of jumpTo feature.

it fixes #128951

… timeline

x-pack/plugins/session_view/common/utils/sort_processes.ts

x-pack/plugins/security_solution/public/timelines/components/timeline/body/actions/index.tsx

zizhouW

LGTM! The following are just some preemptive comments on some of the "trickier" (imo) conflicts that we might see with the changes in #129149

x-pack/plugins/session_view/public/components/process_tree/helpers.ts

x-pack/plugins/session_view/public/components/process_tree_alerts/index.tsx

x-pack/plugins/session_view/public/components/process_tree_node/index.tsx

x-pack/plugins/session_view/public/components/session_view/hooks.ts

…nto session_view_config

x-pack/plugins/security_solution/public/timelines/components/timeline/body/actions/index.tsx

x-pack/plugins/session_view/common/constants.ts

x-pack/plugins/session_view/public/components/detail_panel_alert_tab/index.tsx

x-pack/plugins/session_view/public/components/process_tree/helpers.ts

opauloh

LGTM - just some questions

…nto session_view_config

kibana-ci · 2022-04-05T19:35:44Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	4.9MB	4.9MB	+370.0B
`sessionView`	56.5KB	56.8KB	+260.0B
total			+630.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`securitySolution`	18	19	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`securitySolution`	251.6KB	251.6KB	+11.0B

History

💚 Build #36060 succeeded 64661e5
💛 Build #36059 was flaky 821d42a
💔 Build #36054 failed 1f2eba0
💔 Build #36039 failed 15499a5
💔 Build #35996 failed 386db33
💔 Build #35976 failed 697ef93

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kqualters-elastic

lgtm 👍

…129275) * Fix for process event pagination in session view * plumbing work to get a few more props to session view when loaded via timeline * session config plumbing work done * jump to event kinks worked out. * tests fixed * test fix * build error fixes * addressed PR comments. cleanup * addressed PR comments. cleanup * post merge fixes * pr comments addressed Co-authored-by: mitodrummer <[email protected]> (cherry picked from commit 772205f)

kibanamachine · 2022-04-05T22:24:02Z

💚 All backports created successfully

Status	Branch	Result
✅	8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…129275) (#129543) * Fix for process event pagination in session view * plumbing work to get a few more props to session view when loaded via timeline * session config plumbing work done * jump to event kinks worked out. * tests fixed * test fix * build error fixes * addressed PR comments. cleanup * addressed PR comments. cleanup * post merge fixes * pr comments addressed Co-authored-by: mitodrummer <[email protected]> (cherry picked from commit 772205f) Co-authored-by: Karl Godard <[email protected]>

mitodrummer and others added 12 commits March 23, 2022 12:31

Fix for process event pagination in session view

462adf2

Merge branch 'main' of github.com:mitodrummer/kibana

4b04f14

Merge branch 'elastic:main' into main

f4229ea

Merge branch 'elastic:main' into main

60a3626

Merge branch 'elastic:main' into main

cbe4ffb

Merge branch 'elastic:main' into main

845cd5d

Merge branch 'elastic:main' into main

40bd685

Merge branch 'elastic:main' into main

ef424f6

plumbing work to get a few more props to session view when loaded via…

812bd3a

… timeline

session config plumbing work done

0c46a84

jump to event kinks worked out.

616ed74

tests fixed

014c600

mitodrummer requested review from zizhouW, opauloh and a team April 2, 2022 07:29

mitodrummer requested review from a team as code owners April 2, 2022 07:29

mitodrummer added bug Fixes for quality problems that affect the customer experience v8.2.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 2, 2022

mitodrummer and others added 2 commits April 2, 2022 01:37

test fix

18baf5f

Merge branch 'main' into session_view_config

193b186

zizhouW reviewed Apr 4, 2022

View reviewed changes

x-pack/plugins/session_view/common/utils/sort_processes.ts Outdated Show resolved Hide resolved

kqualters-elastic reviewed Apr 4, 2022

View reviewed changes

x-pack/plugins/security_solution/public/timelines/components/timeline/body/actions/index.tsx Outdated Show resolved Hide resolved

zizhouW approved these changes Apr 4, 2022

View reviewed changes

mitodrummer and others added 3 commits April 4, 2022 11:46

build error fixes

6a21be6

Merge branch 'session_view_config' of github.com:mitodrummer/kibana i…

697ef93

…nto session_view_config

Merge branch 'main' into session_view_config

386db33

opauloh reviewed Apr 4, 2022

View reviewed changes

x-pack/plugins/security_solution/public/timelines/components/timeline/body/actions/index.tsx Outdated Show resolved Hide resolved

opauloh reviewed Apr 4, 2022

View reviewed changes

x-pack/plugins/session_view/common/constants.ts Outdated Show resolved Hide resolved

mitodrummer and others added 6 commits April 4, 2022 14:34

addressed PR comments. cleanup

2c66f7f

addressed PR comments. cleanup

15499a5

Merge branch 'elastic:main' into main

5ae911e

Merge branch 'main' into session_view_config

1f2eba0

post merge fixes

821d42a

Merge branch 'main' into session_view_config

64661e5

mitodrummer requested a review from kqualters-elastic April 5, 2022 05:53

opauloh reviewed Apr 5, 2022

View reviewed changes

x-pack/plugins/session_view/public/components/detail_panel_alert_tab/index.tsx Show resolved Hide resolved

opauloh reviewed Apr 5, 2022

View reviewed changes

x-pack/plugins/session_view/public/components/process_tree/helpers.ts Show resolved Hide resolved

opauloh approved these changes Apr 5, 2022

View reviewed changes

mitodrummer and others added 3 commits April 5, 2022 10:46

pr comments addressed

b931b0e

Merge branch 'session_view_config' of github.com:mitodrummer/kibana i…

543e73c

…nto session_view_config

Merge branch 'main' into session_view_config

d1d14fa

mitodrummer requested a review from a team April 5, 2022 17:49

mitodrummer requested review from YulNaumenko and michaelolo24 April 5, 2022 21:18

mitodrummer enabled auto-merge (squash) April 5, 2022 21:41

kqualters-elastic approved these changes Apr 5, 2022

View reviewed changes

mitodrummer merged commit 772205f into elastic:main Apr 5, 2022

kibanamachine mentioned this pull request Apr 5, 2022

[8.2] [Session View] jumpToEntityId / investigatedAlertId behavior fixed. (#129275) #129543

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Session View] jumpToEntityId / investigatedAlertId behavior fixed. #129275

[Session View] jumpToEntityId / investigatedAlertId behavior fixed. #129275

mitodrummer commented Apr 2, 2022 •

edited by opauloh

Loading

zizhouW left a comment •

edited

Loading

opauloh left a comment

kibana-ci commented Apr 5, 2022

kqualters-elastic left a comment

kibanamachine commented Apr 5, 2022

[Session View] jumpToEntityId / investigatedAlertId behavior fixed. #129275

[Session View] jumpToEntityId / investigatedAlertId behavior fixed. #129275

Conversation

mitodrummer commented Apr 2, 2022 • edited by opauloh Loading

Summary

QA

zizhouW left a comment • edited Loading

Choose a reason for hiding this comment

opauloh left a comment

Choose a reason for hiding this comment

kibana-ci commented Apr 5, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Public APIs missing exports

Page load bundle

History

kqualters-elastic left a comment

Choose a reason for hiding this comment

kibanamachine commented Apr 5, 2022

💚 All backports created successfully

Questions ?

mitodrummer commented Apr 2, 2022 •

edited by opauloh

Loading

zizhouW left a comment •

edited

Loading