Support v6 mappings for saved objects import/export #12792
Conversation
src/ui/public/utils/mapping_setup.js
Outdated
| @@ -76,6 +76,7 @@ export default function MappingSetupService(kbnIndex, esAdmin) { | |||
| const prom = getKnownKibanaTypes() | |||
| .then(function (knownTypes) { | |||
| // if the type is in the knownTypes array already | |||
| return false; | |||
There was a problem hiding this comment.
Hack until #12793 is resolved.
Signed-off-by: Tyler Smalley <[email protected]>
tylersmalley
force-pushed
the
saved-objects-export
branch
from
b702c4b to
0ca1ee1
Compare
|
jenkins, test this |
1 similar comment
|
jenkins, test this |
|
region map test failure looks unrelated. Looking into it.. |
|
jenkins, test this |
| @@ -53,7 +53,6 @@ export function SavedObjectProvider(esAdmin, kbnIndex, Promise, Private, Notifie | |||
|
|
|||
| // type name for this object, used as the ES-type | |||
| const esType = config.type; | |||
| this.index = kbnIndex; | |||
There was a problem hiding this comment.
Why did you remove this? Are you sure this doesn't have trickle down effects elsewhere, on xpack or something?
There was a problem hiding this comment.
I couldn't find any instance of it being used and never ran into an error when testing.
There was a problem hiding this comment.
This is why I love getters so much, easier to find uses but mostly that unexpected accesses that are broken by changes/removal are much louder
|
I'm noticing an issue with this: If I have a fresh install of Elasticsearch/Kibana and I create my first index pattern. The first time I navigate to discover, I get warning notification. This is easily repeatedly by deleting the index pattern, refreshing, creating it again, and then navigating to discover.
|
|
Regarding my previous comment, the data does load in discover, so I'm not really sure what this is warning about. |
|
I am fairly certain this is caused by the session storage. The dashboard is attempting to redirect you back to the page you were previously on which contained an index pattern you since deleted. |
|
Yep, you're right. |
|
In a separate PR we should probably change that error message to |
|
LGTM |
Signed-off-by: Tyler Smalley <[email protected]>
Signed-off-by: Tyler Smalley <[email protected]>
| _id: hit._id.replace(`${this.type}:`, ''), | ||
| _type: this.type, | ||
| _source: hit._source[this.type], | ||
| _meta: { |
jimgoodwin
added
Team:Operations
Buried in here is a change that closes #10779