-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uses SavedObjectsClient for Short URL Lookup #12787
Uses SavedObjectsClient for Short URL Lookup #12787
Conversation
5893062
to
e5dac08
Compare
@tylersmalley from what I can determine, we were originally creating the ID based on a md5 hash of the long-url, so that we don't end up creating a bunch of redundant documents in the With the way that the short-url is implemented via the UI, this could be problematic. Every time that you click the "Short URL" button in Kibana, it's calling the This is the way that it used to work if I continually toggle between short urls and long urls, you'll notice that the ID stays the same, and only one document is created: This is how it works with these changes, keep in mind every time you see the short-id change it's created a new document: |
e5dac08
to
ebb93fb
Compare
@kobelb, updated.
|
Signed-off-by: Tyler Smalley <[email protected]>
ebb93fb
to
00973dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Tyler Smalley <[email protected]>
5.x/5.6: 8d1bbd9 |
No description provided.