Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console] Remove use of jQuery #127867

Merged
merged 13 commits into from
Apr 7, 2022
Merged

[Console] Remove use of jQuery #127867

merged 13 commits into from
Apr 7, 2022

Conversation

mibragimov
Copy link
Contributor

@mibragimov mibragimov commented Mar 16, 2022 •
edited
Loading

Closes #75861

Summary

This PR addresses removing jQuery from Console.

@mibragimov mibragimov added release_note:enhancement Feature:Console Dev Tools Console Feature Feature:Dev Tools Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.3.0 labels Mar 16, 2022
@mibragimov mibragimov self-assigned this Mar 16, 2022
@alexwizp
Copy link
Contributor

@mibragimov please add more detailed description for your PR's. It is important for me to see the part that has been changed in order to make it easier to review the code.

@alexwizp
Copy link
Contributor

@elasticmachine merge upstream

alexwizp
alexwizp reviewed Mar 23, 2022
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed the first round of the review. Please review and correct comments

@alexwizp alexwizp added v8.2.0 and removed v8.3.0 labels Mar 25, 2022
@alexwizp alexwizp marked this pull request as ready for review March 25, 2022 12:48
@alexwizp alexwizp requested a review from a team as a code owner March 25, 2022 12:48
@alexwizp alexwizp requested a review from sabarasaba March 25, 2022 12:48
@mibragimov
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

expected head sha didn’t match current head ref.

@mibragimov
Copy link
Contributor Author

@elasticmachine merge upstream

1 similar comment
@mibragimov
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp alexwizp requested a review from hro-maker March 29, 2022 07:18
@mibragimov
Copy link
Contributor Author

@elasticmachine merge upstream

2 similar comments
@mibragimov
Copy link
Contributor Author

@elasticmachine merge upstream

@mibragimov
Copy link
Contributor Author

@elasticmachine merge upstream

sabarasaba
sabarasaba approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback and adding tests for send_request_to_es.test @mibragimov! I left one small thing that I think we should correct before merging, but other than that the rest lgtm 🥳

@sabarasaba
Copy link
Member

Another thing, v8.2.0 is past feature freeze so we should only target v8.3.0. Also since this is a PR that is an internal enhancement that is not user facing, I believe we would want to use the release note: skip tag instead of the one we have now.

@nickpeihl nickpeihl mentioned this pull request Apr 6, 2022
Merged
@mibragimov mibragimov added release_note:skip Skip the PR/issue when compiling release notes v8.3.0 and removed release_note:enhancement v8.2.0 labels Apr 7, 2022
@mibragimov mibragimov mentioned this pull request Apr 7, 2022
Closed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
console 169 172 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
console 380.1KB 380.2KB +131.0B

History

  • 💚 Build #36064 succeeded 9456eba48e7df292625b986002f5e41226d65574
  • 💛 Build #35754 was flaky 33c532ecf53af59ea783ac8eed59ba968fd2c7a5
  • 💚 Build #35537 succeeded ffcfca0e258563947b9637ea8b47ca874c27de36
  • 💔 Build #35480 failed a6e826571f6ec3edf63d640ea8b2ac6ef5cf4eec
  • 💚 Build #35436 succeeded 937d3fb0087dbacd86126dec4c761cd75278d05c
  • 💚 Build #34820 succeeded 9f7696449dd5156ff09dc7664fee9f2a6b188ce2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mibragimov

@mibragimov mibragimov merged commit 8a0cc6e into elastic:main Apr 7, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 7, 2022
@mibragimov mibragimov deleted the remove-jquery branch April 7, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal left review comments

@yuliacech yuliacech yuliacech left review comments

@sabarasaba sabarasaba sabarasaba approved these changes

@alexwizp alexwizp alexwizp approved these changes

@maksimkovalev maksimkovalev Awaiting requested review from maksimkovalev

@hro-maker hro-maker Awaiting requested review from hro-maker

Assignees

@mibragimov mibragimov

Labels
backport:skip This commit does not require backporting Feature:Console Dev Tools Console Feature Feature:Dev Tools release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Console] Remove use of jQuery and use platform provided http client
7 participants
@mibragimov @alexwizp @kibanamachine @sabarasaba @kibana-ci @cjcenizal @yuliacech