Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y tests for license management page #127497

Merged
merged 14 commits into from
Mar 14, 2022
Merged

A11y tests for license management page #127497

merged 14 commits into from
Mar 14, 2022

Conversation

bhavyarm
Copy link
Contributor

A11y tests for license management page
Meta - #51456

@bhavyarm bhavyarm self-assigned this Mar 10, 2022
@bhavyarm bhavyarm mentioned this pull request Mar 10, 2022
Open
77 tasks
@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@bhavyarm bhavyarm added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 10, 2022
@bhavyarm
Copy link
Contributor Author

flaky test runner job - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/265

@elastic elastic deleted a comment from kibanamachine Mar 10, 2022
@bhavyarm
Copy link
Contributor Author

Fixed a type error which I stubbornly refused to acknowledge as mine. And then there was a jest snapshot error. All updated. Here is the new flaky test - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/276

@bhavyarm bhavyarm marked this pull request as ready for review March 14, 2022 13:41
@bhavyarm bhavyarm requested a review from a team as a code owner March 14, 2022 13:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@bhavyarm bhavyarm requested a review from LeeDr March 14, 2022 13:41
@bhavyarm
Copy link
Contributor Author

bhavyarm commented Mar 14, 2022 •
edited
Loading

Please note the previous flaky test runner passed through fine for default accessibility group. I have no idea why it triggered a test on oss group. Running again - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/278

@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

yuliacech
yuliacech approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding a11y tests, @bhavyarm! Changes LGTM 👍

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
licenseManagement 61.1KB 61.1KB +46.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

rashmivkulkarni
rashmivkulkarni approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@rashmivkulkarni rashmivkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
++ for more tests!

LeeDr
LeeDr approved these changes Mar 14, 2022
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhavyarm bhavyarm removed the v8.0.2 label Mar 14, 2022
@bhavyarm bhavyarm merged commit faa3fc6 into elastic:main Mar 14, 2022
@kibanamachine kibanamachine mentioned this pull request Mar 14, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Mar 14, 2022
@bhavyarm
A11y tests for license management page (#127497)
50fedc1 
(cherry picked from commit faa3fc6)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 14, 2022
@kibanamachine @bhavyarm
A11y tests for license management page (#127497) (#127626)
713b07d 
(cherry picked from commit faa3fc6)

Co-authored-by: Bhavya RM <[email protected]>
@bhavyarm bhavyarm mentioned this pull request Mar 14, 2022
Merged
maksimkovalev pushed a commit to maksimkovalev/kibana that referenced this pull request Mar 18, 2022
@bhavyarm @maksimkovalev
A11y tests for license management page (elastic#127497)
d4beb5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuliacech yuliacech yuliacech approved these changes

@rashmivkulkarni rashmivkulkarni rashmivkulkarni approved these changes

@LeeDr LeeDr LeeDr approved these changes

Assignees

@bhavyarm bhavyarm

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:License Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional v8.1.1 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bhavyarm @elasticmachine @kibana-ci @kibanamachine @yuliacech @rashmivkulkarni @LeeDr