Fix multi terms performance bottleneck #126575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Team:Visualizations
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
|
Pinging @elastic/kibana-app-services (Team:AppServicesSv) |
dej611
reviewed
Mar 1, 2022
x-pack/plugins/lens/public/xy_visualization/color_assignment.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Marco Liberati <[email protected]>
dej611
reviewed
Mar 1, 2022
Comment on lines
+142
to
+148
| const isCached = this.formatCache.has(fieldParams); | ||
| const cachedFormat = | ||
| this.formatCache.get(fieldParams) || | ||
| getFieldFormat({ id: fieldParams.id, params: fieldParams }); | ||
| if (!isCached) { | ||
| this.formatCache.set(fieldParams, cachedFormat); | ||
| } |
There was a problem hiding this comment.
nit: inverting the order will remove few lines
Suggested change
| const isCached = this.formatCache.has(fieldParams); | |
| const cachedFormat = | |
| this.formatCache.get(fieldParams) || | |
| getFieldFormat({ id: fieldParams.id, params: fieldParams }); | |
| if (!isCached) { | |
| this.formatCache.set(fieldParams, cachedFormat); | |
| } | |
| if (!this.formatCache.has(fieldParams);) { | |
| this.formatCache.set( | |
| fieldParams, | |
| getFieldFormat({ id: fieldParams.id, params: fieldParams }) | |
| ); | |
| } | |
| return this.formatCache.get(fieldParams); |
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
dej611
approved these changes
Mar 2, 2022
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 3, 2022
(cherry picked from commit 555ec91)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 3, 2022
(cherry picked from commit 555ec91) Co-authored-by: Joe Reuter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drastically reduces the number of times new formatter instances as constructed, speeding up rendering of chart with lots of data points especially if they are using multi terms (because it would instantiate new formatter instances for each part of the key from scratch on each formatting).
Before:
After:
There are a few other things to improve but those are to most relevant ones.