Test yarn-deduplicate

[jportner]

Testing for #125712

[jportner]

Note to self when I pick this back up: graceful-fs had some breaking changes in a minor upgrade which we ran into when trying to deduplicate dependencies in another PR (18c3017)

[jportner]

I rebased on main and fixed a few more issues.

Not sure why we are seeing prop-types type errors, I tried rolling back @types/prop-types to the previous version (edit: found the problem, see #125741 (comment))

Haven't started looking into the a11y errors yet.

[jportner]

This is so strange, I'm seeing PropTypes-related TS errors all over the place. This appears to be due to changes in @types/prop-types, though I can't figure out what in that package's commit history is causing it.

Collapsing the two @types/prop-types dependencies like this does NOT work:

"@types/prop-types@*", "@types/prop-types@^15.7.3":
  version "15.7.3"
  resolved "https://registry.yarnpkg.com/@types/prop-types/-/prop-types-15.7.3.tgz#2ab0d5da2e5815f94b0b9d4b95d1e5f243ab2ca7"
  integrity sha512-KfRL3PuHmqQLOG+2tGpRO26Ctg+Cq1E01D2DMriKEATHgWLfeNDmq9e29Q9WIky0dQ3NPkd1mzYH8Lm936Z9qw==

I see errors like this one in x-pack/plugins/canvas/public/expression_types/arg_types/series_style/index.ts:

Conversely, pinning it to the earlier 15.7.1 (by modifying package.json), resulting in this in the lockfile, also does NOT work:

"@types/prop-types@*", "@types/[email protected]":
  version "15.7.1"
  resolved "https://registry.yarnpkg.com/@types/prop-types/-/prop-types-15.7.1.tgz#f1a11e7babb0c3cad68100be381d1e064c68f1f6"
  integrity sha512-CFzn9idOEpHrgdw8JsoTkaDDyRWk1jrzIV8djzcgpq0y9tG4B4lFT+Nxh52DVpDXV+n4+NPNv7M1Dj5uMp6XFg==

I see similar errors:

The only thing that seems to work without type errors is this, which is what is in the lockfile today:

"@types/prop-types@*":
  version "15.7.1"
  resolved "https://registry.yarnpkg.com/@types/prop-types/-/prop-types-15.7.1.tgz#f1a11e7babb0c3cad68100be381d1e064c68f1f6"
  integrity sha512-CFzn9idOEpHrgdw8JsoTkaDDyRWk1jrzIV8djzcgpq0y9tG4B4lFT+Nxh52DVpDXV+n4+NPNv7M1Dj5uMp6XFg==

"@types/prop-types@^15.7.3":
  version "15.7.3"
  resolved "https://registry.yarnpkg.com/@types/prop-types/-/prop-types-15.7.3.tgz#2ab0d5da2e5815f94b0b9d4b95d1e5f243ab2ca7"
  integrity sha512-KfRL3PuHmqQLOG+2tGpRO26Ctg+Cq1E01D2DMriKEATHgWLfeNDmq9e29Q9WIky0dQ3NPkd1mzYH8Lm936Z9qw==

I was able to prevent these two from being combined by adding a yarn dependency resolution:

"**/@types/prop-types": "15.7.1",

[kibana-ci]

💔 Build Failed

• Buildkite Build
• Commit: f057cc3
• Interpreting CI Failures
• Storybooks Preview
• Webpack Bundle Analyzer

Failed CI Steps

• OSS Accessibility Tests
• OSS Accessibility Tests
• Default Accessibility Tests
• Default Accessibility Tests
• Checks

Test Failures

• [job] [logs] OSS Accessibility Tests / a11y tests using flights sample data Discover a11y tests a11y test on tables with columns view
• [job] [logs] OSS Accessibility Tests / a11y tests using flights sample data Discover a11y tests a11y test on tables with columns view
• [job] [logs] Default Accessibility Tests / Kibana Home Enterprise search overview page meets a11y requirements
• [job] [logs] Default Accessibility Tests / Kibana Home Enterprise search overview page meets a11y requirements

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
dashboard	267	277	+10
enterpriseSearch	1466	1468	+2
fileUpload	180	208	+28
total			+40

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
kibanaReact	204	203	-1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
dashboard	295.4KB	324.2KB	+28.8KB
dataViewEditor	170.1KB	170.2KB	+74.0B
enterpriseSearch	1.5MB	1.5MB	+9.1KB
fileUpload	821.1KB	857.4KB	+36.3KB
maps	2.6MB	2.6MB	+155.0B
ml	3.3MB	3.3MB	+238.0B
spaces	284.5KB	284.6KB	+74.0B
total			+74.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
discover	40.3KB	40.4KB	+74.0B
kbnUiSharedDeps-npmDll	4.8MB	4.8MB	-29.0KB
kbnUiSharedDeps-srcJs	3.8MB	3.8MB	+1.2KB
presentationUtil	44.6KB	44.8KB	+208.0B
total			-27.5KB

History

• 💔 Build #39602 failed e60aa22fe1f54fae103247a5e412b7ce6a3d4de0
• 💔 Build #39547 failed a85215a1397faf8bd584768749f0fbf05473604e
• 💔 Build #39524 failed 2d0c6a0
• 💔 Build #39167 failed 6c0ad49

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream