Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data depends on security #124796

Closed
wants to merge 6 commits into from
Closed

Conversation

afharo
Copy link
Member

@afharo afharo commented Feb 7, 2022

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@@ -10,6 +10,6 @@
"server": true,
"ui": true,
"extraPublicDirs": ["common/lib"],
"requiredPlugins": ["savedObjects", "kibanaReact", "embeddable", "expressions", "dataViews"],
Copy link
Member Author

@afharo afharo Feb 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It caused a circular dependency, so I copied the deprecated SavedObjectSaveModal into this plugin

@kibana-ci
Copy link
Collaborator

kibana-ci commented Feb 8, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] OSS Accessibility Tests / a11y tests using flights sample data Dashboard create dashboard button
  • [job] [logs] Default CI Group #10 / Actions and Triggers app Home page Loads the app Loads the Alerts page
  • [job] [logs] Default CI Group #10 / Actions and Triggers app Home page Loads the app with limited privileges Loads the Alerts page
  • [job] [logs] Default CI Group #2 / Advanced Settings security feature controls global advanced_settings all privileges "before all" hook for "shows management navlink"
  • [job] [logs] Default CI Group #13 / Grok Debugger App Grok Debugger "before all" hook for "Loads the app"
  • [job] [logs] Default CI Group #13 / Grok Debugger App Grok Debugger "before all" hook for "Loads the app"
  • [job] [logs] Default CI Group #15 / machine learning permissions for user with full ML access with data loaded (ft_ml_poweruser_spaces) should display elements on ML Overview page correctly
  • [job] [logs] Default CI Group #15 / machine learning permissions for user with full ML access with no data loaded (ft_ml_poweruser) "before all" hook for "should display the ML entry in Kibana app menu"
  • [job] [logs] Default CI Group #2 / Reporting Functional Tests with Security enabled Security with reporting_user built-in role Dashboard: Download CSV file does not allow user that does not have reporting privileges
  • [job] [logs] Jest Tests #3 / rolesManagementApp mount() works for the clone role page
  • [job] [logs] Jest Tests #3 / rolesManagementApp mount() works for the create role page
  • [job] [logs] Jest Tests #3 / rolesManagementApp mount() works for the edit role page
  • [job] [logs] OSS Misc Functional Tests / runPipeline "before all" hook in "runPipeline"
  • [job] [logs] OSS CI Group #7 / saved objects management saved objects relationships flyout displays the invalid references
  • [job] [logs] Default CI Group #21 / transform permissions for user with full transform access with no data loaded "before all" hook for "should display elements in the Transform list page correctly"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
embeddable 75 81 +6
presentationUtil 172 176 +4
total +10

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
embeddable 381 382 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
presentationUtil 135.1KB 140.2KB +5.1KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
embeddable 4 5 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 65.2KB 77.6KB +12.4KB
esUiShared 122.5KB 122.5KB -21.0B
presentationUtil 44.9KB 44.8KB -142.0B
security 50.1KB 50.1KB -5.0B
total +12.3KB
Unknown metric groups

API count

id before after diff
embeddable 468 469 +1

ESLint disabled in files

id before after diff
apm 15 14 -1

ESLint disabled line counts

id before after diff
apm 86 83 -3

References to deprecated APIs

id before after diff
embeddable 7 5 -2
presentationUtil 2 0 -2
total -4

Total ESLint disabled count

id before after diff
apm 101 97 -4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo closed this Mar 31, 2022
@afharo afharo deleted the data-depends-on-security branch March 31, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants