-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Adding update datafeed API test #124540
[ML] Adding update datafeed API test #124540
Conversation
Pinging @elastic/ml-ui (:ml) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
* [ML] Adding update datafeed API test * updating tests Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 9b284e7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
* [ML] Adding update datafeed API test * updating tests Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 9b284e7) Co-authored-by: James Gowdy <[email protected]>
Adds test to update the query delay in an existing datafeed.
This is kibana endpoint is a proxy to the elasticsearch endpoint and so does not need exhaustive testing, we only need to ensure the endpoint is working.
Coverage is needed due to this issue where changes to the esclient upstream broke the update datafeed functionality in the UI.
Related to #117501