Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Adding update datafeed API test #124540

Merged

Conversation

jgowdyelastic
Copy link
Member

Adds test to update the query delay in an existing datafeed.
This is kibana endpoint is a proxy to the elasticsearch endpoint and so does not need exhaustive testing, we only need to ensure the endpoint is working.

Coverage is needed due to this issue where changes to the esclient upstream broke the update datafeed functionality in the UI.

Related to #117501

@jgowdyelastic jgowdyelastic added non-issue Indicates to automation that a pull request should not appear in the release notes :ml Feature:Anomaly Detection ML anomaly detection release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v8.2.0 labels Feb 3, 2022
@jgowdyelastic jgowdyelastic self-assigned this Feb 3, 2022
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner February 3, 2022 15:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit 9b284e7 into elastic:main Feb 4, 2022
@jgowdyelastic jgowdyelastic deleted the adding-update-datafeed-api-test branch February 4, 2022 12:56
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 4, 2022
* [ML] Adding update datafeed API test

* updating tests

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 9b284e7)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 4, 2022
* [ML] Adding update datafeed API test

* updating tests

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 9b284e7)

Co-authored-by: James Gowdy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes test-api-integration v8.1.0 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants