Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use docLinks service for ui settings in Discover and Data plugins #124302

Merged
merged 6 commits into from
Feb 4, 2022
Merged

Use docLinks service for ui settings in Discover and Data plugins #124302

merged 6 commits into from
Feb 4, 2022

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Feb 1, 2022

Summary

This PR replaces the hard-coded documentation links for ui settings in Discover and Data plugins with the docLinks service. This is now possible thanks to the DocLinks service being available on the server-side #123818.

Reviewer hints:

  • kbn-doc-links: Add a new link to the Field statistics page under discover
  • Discover: Add docLinks service to getUiSettings()
  • Data: Add docLinks service to getUiSettings()

Checklist

Delete any items that are not applicable to this PR.

@qn895 qn895 added the v8.1.0 label Feb 1, 2022
@qn895 qn895 requested a review from lcawl February 1, 2022 22:44
@qn895 qn895 assigned lcawl and qn895 Feb 1, 2022
@lcawl lcawl marked this pull request as ready for review February 2, 2022 00:20
@lcawl lcawl requested review from a team as code owners February 2, 2022 00:20
@lcawl lcawl added enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes labels Feb 2, 2022
@lcawl lcawl mentioned this pull request Feb 2, 2022
Closed
kertal
kertal approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, reviewed DataDiscovery.team code, tested those links online work, nice change, much better than hardcoding link 👍

lcawl
lcawl approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc link choices LGTM!

@qn895
Copy link
Member Author

qn895 commented Feb 4, 2022

@elasticmachine merge upstream

@qn895 qn895 added auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 labels Feb 4, 2022
@qn895 qn895 enabled auto-merge (squash) February 4, 2022 18:07
@qn895 qn895 disabled auto-merge February 4, 2022 21:03
@qn895 qn895 enabled auto-merge (squash) February 4, 2022 21:03
@qn895 qn895 disabled auto-merge February 4, 2022 21:03
@qn895
Copy link
Member Author

qn895 commented Feb 4, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 292.5KB 292.6KB +89.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lcawl @qn895

@lcawl lcawl merged commit 2446d11 into elastic:main Feb 4, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 4, 2022
@qn895 @kibanamachine
Use docLinks service for ui settings in Discover and Data plugins (el…
672f9e5 
…astic#124302)

(cherry picked from commit 2446d11)
@kibanamachine kibanamachine mentioned this pull request Feb 4, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 5, 2022
@kibanamachine @qn895
Use docLinks service for ui settings in Discover and Data plugins (#1…
4a363d3 
…24302) (#124765)

(cherry picked from commit 2446d11)

Co-authored-by: Quynh Nguyen <[email protected]>
@qn895 qn895 deleted the discover-data-doc-links-service branch February 7, 2022 16:54
@lcawl lcawl mentioned this pull request Feb 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

@tsullivan tsullivan tsullivan approved these changes

@lcawl lcawl lcawl approved these changes

Assignees

@lcawl lcawl

@qn895 qn895

Labels
auto-backport Deprecated - use backport:version if exact versions are needed enhancement New value added to drive a business result Feature:uiSettings release_note:skip Skip the PR/issue when compiling release notes v8.1.0 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qn895 @kibana-ci @kibanamachine @kertal @tsullivan @lcawl