Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elasticsearch.queries -> elasticsearch.query #119941

Merged
merged 2 commits into from
Nov 30, 2021

Conversation

rudolf
Copy link
Contributor

@rudolf rudolf commented Nov 30, 2021

Summary

When we introduced the deprecation logs in #89296 we incorrectly told users to use elasticsearch.queries context instead of the elasticsearch.query context.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@rudolf rudolf added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 v8.1.0 v7.16.1 labels Nov 30, 2021
@rudolf rudolf requested a review from a team as a code owner November 30, 2021 10:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rudolf rudolf merged commit 9ec41f7 into elastic:main Nov 30, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 30, 2021
* Fix elasticsearch.queries -> elasticsearch.query

* Fix another elasticsearch.queries -> elasticsearch.query
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
8.0
7.16 Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 119941

kibanamachine added a commit that referenced this pull request Nov 30, 2021
* Fix elasticsearch.queries -> elasticsearch.query

* Fix another elasticsearch.queries -> elasticsearch.query

Co-authored-by: Rudolf Meijering <[email protected]>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
* Fix elasticsearch.queries -> elasticsearch.query

* Fix another elasticsearch.queries -> elasticsearch.query
@rudolf rudolf deleted the elasticsearch-query branch May 16, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.16.0 v7.16.1 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants