[App Search] Add accordion lists for Domains, Seed URLs, and Sitemap URLs to Crawl Details Flyout #119682

byronhulcher · 2021-11-24T23:44:57Z

Summary

Adds a new AccordionList component
Adds the Domains, Seed URLs, and Sitemap URLs lists (implemented using AccordionList to the existing CrawlDetailsFlyout component)

Screenshots

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

daveyholler · 2021-11-24T23:57:28Z

Can we set a max width on that fly out? I'm on my phone right now, but I believe that the medium size is appropriate.

orhantoy · 2021-11-30T12:37:20Z

@elasticmachine merge upstream

daveyholler · 2021-11-30T23:11:50Z

...pplications/app_search/components/crawler/components/crawl_details_flyout/accordion_list.tsx

+  hasBorder?: boolean;
+  initialIsOpen?: boolean;


hasBorder allows the accordion to be rendered with or without a border and padding. I've got some designs in the works that will use be making use of this component in both scenarios.

initialIsOpen allows the accordion to be expanded. In this case specifically, we set the prop to true when items exist in the list.

daveyholler · 2021-11-30T23:12:24Z

...pplications/app_search/components/crawler/components/crawl_details_flyout/accordion_list.tsx

-        pagination={{
+        pagination={ items.length > 10 ? {
          hidePerPageOptions: true,
-        }}
+        } : false}


I'm hiding pagination when there's only one page of items.

orhantoy

To me it looks like we have a lot of borders:

We could either increase the whitespace between the sections or it might help to remove the bottom border on the tables.

Also, it says "No items found" which reads a bit weird. But it looks like EuiInMemoryTable has that built-in somehow, so I'm not sure if we have control over that message.

...app_search/components/crawler/components/crawl_details_flyout/crawl_details_preview.test.tsx

...pplications/app_search/components/crawler/components/crawl_details_flyout/accordion_list.tsx

daveyholler · 2021-12-01T16:55:12Z

To me it looks like we have a lot of borders...

I agree. I'll explore some possible CSS options. In my designs I actually removed the bottom border on the table which helps.

kibana-ci · 2021-12-01T19:13:18Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`enterpriseSearch`	1328	1334	+6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`enterpriseSearch`	1.3MB	1.3MB	+2.9KB

History

💔 Build #10221 failed c680d3e
💔 Build #10204 failed 6204c15
💔 Build #10125 failed f7e93f8
💚 Build #9951 succeeded d68574b
💚 Build #9188 succeeded 9c52fc5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @daveyholler @byronhulcher

…URLs to Crawl Details Flyout (elastic#119682) * New AccordionList component * Add a domains accordion list to the CrawlDetailsPreview * Add seedUrls to CrawlConfig * Add a seed urls accordion list to the CrawlDetailsPreview * Add sitemapUrls to CrawlConfig * Add a sitemap urls accordion list to the CrawlDetailsPreview * Disable arrow in AccordionList when items are empty * Add spacers to CrawlDetailsPreview * Type fix * Sets a maxWidth on the flyout. * Allows the raw JSON to be copied. * Visual updates to the accordions. * Linting * Review and linting fixes. * Styles the tables in the accordion list. * Uses a subdued color for count badges when the count is zero. Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Davey Holler <[email protected]>

kibanamachine · 2021-12-01T19:53:16Z

💚 Backport successful

Status	Branch	Result
✅	8.0

This backport PR will be merged automatically after passing CI.

…URLs to Crawl Details Flyout (#119682) (#120160) * New AccordionList component * Add a domains accordion list to the CrawlDetailsPreview * Add seedUrls to CrawlConfig * Add a seed urls accordion list to the CrawlDetailsPreview * Add sitemapUrls to CrawlConfig * Add a sitemap urls accordion list to the CrawlDetailsPreview * Disable arrow in AccordionList when items are empty * Add spacers to CrawlDetailsPreview * Type fix * Sets a maxWidth on the flyout. * Allows the raw JSON to be copied. * Visual updates to the accordions. * Linting * Review and linting fixes. * Styles the tables in the accordion list. * Uses a subdued color for count badges when the count is zero. Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Davey Holler <[email protected]> Co-authored-by: Byron Hulcher <[email protected]> Co-authored-by: Davey Holler <[email protected]>

…URLs to Crawl Details Flyout (elastic#119682) * New AccordionList component * Add a domains accordion list to the CrawlDetailsPreview * Add seedUrls to CrawlConfig * Add a seed urls accordion list to the CrawlDetailsPreview * Add sitemapUrls to CrawlConfig * Add a sitemap urls accordion list to the CrawlDetailsPreview * Disable arrow in AccordionList when items are empty * Add spacers to CrawlDetailsPreview * Type fix * Sets a maxWidth on the flyout. * Allows the raw JSON to be copied. * Visual updates to the accordions. * Linting * Review and linting fixes. * Styles the tables in the accordion list. * Uses a subdued color for count badges when the count is zero. Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Davey Holler <[email protected]>

Byron Hulcher added 8 commits November 24, 2021 18:09

New AccordionList component

6c5e07a

Add a domains accordion list to the CrawlDetailsPreview

a6734de

Add seedUrls to CrawlConfig

28af3ae

Add a seed urls accordion list to the CrawlDetailsPreview

2095078

Add sitemapUrls to CrawlConfig

37d82e9

Add a sitemap urls accordion list to the CrawlDetailsPreview

052086c

Disable arrow in AccordionList when items are empty

c6da382

Add spacers to CrawlDetailsPreview

da9d756

byronhulcher added Feature:Plugins v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Nov 24, 2021

byronhulcher self-assigned this Nov 24, 2021

byronhulcher requested a review from a team November 24, 2021 23:44

Type fix

9c52fc5

kibanamachine and others added 3 commits November 30, 2021 07:37

Merge branch 'main' into crawl-details-preview-lists

d68574b

Sets a maxWidth on the flyout.

9956772

Allows the raw JSON to be copied.

f7e93f8

orhantoy assigned daveyholler Nov 30, 2021

Visual updates to the accordions.

6204c15

byronhulcher requested a review from a team as a code owner November 30, 2021 23:09

daveyholler reviewed Nov 30, 2021

View reviewed changes

Linting

c680d3e

orhantoy reviewed Dec 1, 2021

View reviewed changes

Review and linting fixes.

64dbf0d

daveyholler requested a review from orhantoy December 1, 2021 17:28

daveyholler added 2 commits December 1, 2021 09:49

Styles the tables in the accordion list.

828d818

Uses a subdued color for count badges when the count is zero.

f9dd39b

orhantoy approved these changes Dec 1, 2021

View reviewed changes

daveyholler approved these changes Dec 1, 2021

View reviewed changes

daveyholler merged commit 096fb43 into elastic:main Dec 1, 2021

kibanamachine mentioned this pull request Dec 1, 2021

[8.0] [App Search] Add accordion lists for Domains, Seed URLs, and Sitemap URLs to Crawl Details Flyout (#119682) #120160

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[App Search] Add accordion lists for Domains, Seed URLs, and Sitemap URLs to Crawl Details Flyout #119682

[App Search] Add accordion lists for Domains, Seed URLs, and Sitemap URLs to Crawl Details Flyout #119682

byronhulcher commented Nov 24, 2021 •

edited by daveyholler

Loading

daveyholler commented Nov 24, 2021

orhantoy commented Nov 30, 2021

daveyholler Nov 30, 2021

daveyholler Nov 30, 2021

orhantoy left a comment

daveyholler commented Dec 1, 2021

kibana-ci commented Dec 1, 2021

kibanamachine commented Dec 1, 2021

[App Search] Add accordion lists for Domains, Seed URLs, and Sitemap URLs to Crawl Details Flyout #119682

[App Search] Add accordion lists for Domains, Seed URLs, and Sitemap URLs to Crawl Details Flyout #119682

Conversation

byronhulcher commented Nov 24, 2021 • edited by daveyholler Loading

Summary

Screenshots

Checklist

daveyholler commented Nov 24, 2021

orhantoy commented Nov 30, 2021

daveyholler Nov 30, 2021

Choose a reason for hiding this comment

daveyholler Nov 30, 2021

Choose a reason for hiding this comment

orhantoy left a comment

Choose a reason for hiding this comment

daveyholler commented Dec 1, 2021

kibana-ci commented Dec 1, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

kibanamachine commented Dec 1, 2021

💚 Backport successful

byronhulcher commented Nov 24, 2021 •

edited by daveyholler

Loading