Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional tests - stabilize Discover custom URL test #119578

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Nov 24, 2021

Summary

This PR stabilizes the Discover custom URL test by making sure all popover are closed before clicking the Discover hide side bar button.

Closes #119273

@pheyos pheyos added :ml test_ui_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 v8.1.0 labels Nov 24, 2021
@pheyos pheyos self-assigned this Nov 24, 2021
@pheyos pheyos requested a review from a team as a code owner November 24, 2021 10:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos
Copy link
Member Author

pheyos commented Nov 24, 2021

Checking test stability in a flaky test runner job ... no failure in 50 runs ✔️

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pheyos

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos pheyos merged commit cdaa030 into elastic:main Nov 24, 2021
@pheyos pheyos deleted the stabilize_discover_url_test branch November 24, 2021 17:01
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 24, 2021
…19578)

This PR stabilizes the Discover custom URL test by making sure all popover are closed before clicking the Discover hide side bar button.
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
8.0
7.16 Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 119578

kibanamachine added a commit that referenced this pull request Nov 24, 2021
…119641)

This PR stabilizes the Discover custom URL test by making sure all popover are closed before clicking the Discover hide side bar button.

Co-authored-by: Robert Oskamp <[email protected]>
pheyos added a commit to pheyos/kibana that referenced this pull request Nov 25, 2021
…19578)

This PR stabilizes the Discover custom URL test by making sure all popover are closed before clicking the Discover hide side bar button.
# Conflicts:
#	x-pack/test/functional/services/ml/custom_urls.ts
pheyos added a commit that referenced this pull request Nov 25, 2021
…19578) (#119706)

* [ML] Functional tests - stabilize Discover custom URL test (#119578)

This PR stabilizes the Discover custom URL test by making sure all popover are closed before clicking the Discover hide side bar button.
# Conflicts:
#	x-pack/test/functional/services/ml/custom_urls.ts

* cherry pick missing discover page method
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
…19578)

This PR stabilizes the Discover custom URL test by making sure all popover are closed before clicking the Discover hide side bar button.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.16.0 v8.0.0 v8.1.0
Projects
None yet
5 participants