Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Fix existing fields query for epoch_millis dates #119508

Merged
merged 3 commits into from
Nov 29, 2021

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Nov 23, 2021

Fixes #119445

See issues for a way to reproduce this. If the data index contains documents which use epoch_millis dates, the query fails because the time range filter doesn't specify the date format which causes it to fall back to the mapping definition. This PR makes sure the format is specified in the query.

I will add a functional test for dates in epoch_millis in general in a separate Pr

@flash1293 flash1293 added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Feature:Lens auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Nov 23, 2021
@flash1293 flash1293 marked this pull request as ready for review November 23, 2021 19:08
@flash1293 flash1293 requested a review from a team as a code owner November 23, 2021 19:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on Safari 👍

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@mbondyra
Copy link
Contributor

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit 1915a8d into elastic:main Nov 29, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 29, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 29, 2021
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Joe Reuter <[email protected]>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Field existence doesn't work on epoch_millis dates
6 participants