Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add POC waffle viz #11931

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented May 19, 2017

do not review.

This is a POC to test the refactor work for the visualize code-base (cf. - #11786)

This visualization:

  • uses the default-editor
  • custom simple-JS implementation of the visualization

Have been playing a little with the different implementation types:

  • angular based
  • JS-based

@thomasneirynck
Copy link
Contributor Author

cc @marius-dr. This is a small stub. If you're interested, you can use it as a starting point to further develop this. It'd be a good use-case to test the visualize refactor.

@thomasneirynck thomasneirynck changed the title WIP add POC waffle viz [WIP] add POC waffle viz May 19, 2017
@thomasneirynck thomasneirynck requested a review from ppisljar May 19, 2017 20:20
@thomasneirynck thomasneirynck added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label May 19, 2017
@thomasneirynck thomasneirynck force-pushed the feature/visualize_waffle branch from 9192054 to dfeadfc Compare May 22, 2017 14:49
defaults: {}
},
responseHandler: 'basic',
implementsRenderComplete: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is no longer needed ... this now relies on resolving promises

@thomasneirynck thomasneirynck force-pushed the feature/visualize_waffle branch from 731222b to 5d04fd6 Compare May 22, 2017 18:00
@thomasneirynck
Copy link
Contributor Author

closing in favor of #11987

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants