Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Osquery] Fix packs migration script #118453

Merged

Conversation

patrykkopycinski
Copy link
Contributor

Summary

Fixes critical script responsible for migrating Scheduled Query Groups (pre 7.16) to Packs (7.16+)

@patrykkopycinski patrykkopycinski added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Asset Management Security Asset Management Team Feature:Osquery Security Solution Osquery feature auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 v8.1.0 labels Nov 12, 2021
@patrykkopycinski patrykkopycinski requested a review from a team as a code owner November 12, 2021 08:54
@patrykkopycinski patrykkopycinski self-assigned this Nov 12, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-asset-management (Team:Asset Management)

@patrykkopycinski patrykkopycinski force-pushed the fix/osquery-packs-migration branch from 58cc4f7 to a2770fe Compare November 12, 2021 09:06
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
osquery 940.4KB 940.6KB +266.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @patrykkopycinski

@patrykkopycinski patrykkopycinski merged commit bb5e183 into elastic:main Nov 13, 2021
@patrykkopycinski patrykkopycinski deleted the fix/osquery-packs-migration branch November 13, 2021 15:34
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
8.0 Commit could not be cherrypicked due to conflicts
7.16 Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 118453

patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Nov 13, 2021
# Conflicts:
#	x-pack/plugins/osquery/public/components/app.tsx
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Nov 13, 2021
# Conflicts:
#	x-pack/plugins/osquery/public/components/app.tsx
patrykkopycinski added a commit that referenced this pull request Nov 13, 2021
# Conflicts:
#	x-pack/plugins/osquery/public/components/app.tsx
patrykkopycinski added a commit that referenced this pull request Nov 13, 2021
# Conflicts:
#	x-pack/plugins/osquery/public/components/app.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Osquery Security Solution Osquery feature release_note:skip Skip the PR/issue when compiling release notes Team:Asset Management Security Asset Management Team v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants