[Discover] Add EuiErrorBoundary to catch errors in the functionals #117976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majagrubic
changed the title
|
@elasticmachine merge upstream |
majagrubic
added
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
kertal
reviewed
Nov 9, 2021
| @@ -96,21 +97,23 @@ export function DiscoverMainApp(props: DiscoverMainProps) { | |||
| }, [resetSavedSearch, savedSearch]); | |||
|
|
|||
| return ( | |||
| <DiscoverLayoutMemoized | |||
There was a problem hiding this comment.
LGTM, only thing to consider, adding the EuiErrorBoundary in discover_router.tsx would also cover executions in routing, context and doc view. So it would be one EuiErrorBoundray to catch em all 🧙
There was a problem hiding this comment.
Would that not be too aggressive?
There was a problem hiding this comment.
Would there be a disadvantage to catch more potential failures causing a empty Discover rendering? Seen other plugins doing it too:
There was a problem hiding this comment.
change LGTM, will test and then approve
💛 Build succeeded, but was flaky
Test Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kertal
approved these changes
Nov 15, 2021
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Nov 16, 2021
…lastic#117976) * [Discover] Add error boundary to cath errors in functionals * Fix invalid import * Move <EuiErrorBoundary> to router Co-authored-by: Kibana Machine <[email protected]>
majagrubic
pushed a commit
that referenced
this pull request
Nov 16, 2021
…117976) (#118664) * [Discover] Add error boundary to cath errors in functionals * Fix invalid import * Move <EuiErrorBoundary> to router Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
mbondyra
pushed a commit
to mbondyra/kibana
that referenced
this pull request
Nov 19, 2021
…lastic#117976) * [Discover] Add error boundary to cath errors in functionals * Fix invalid import * Move <EuiErrorBoundary> to router Co-authored-by: Kibana Machine <[email protected]>
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
…117976) * [Discover] Add error boundary to cath errors in functionals * Fix invalid import * Move <EuiErrorBoundary> to router Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The primary use of this is to catch the error in:
#81576
This test occasionally fails, with a completely blank screen and is extremely flaky, so hard to reproduce. But the
EuiErrorBoundaryshould helps us with other failures as well.Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers