Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Alerts chart preview wrong timezone #116014

Merged
merged 2 commits into from
Oct 25, 2021
Merged

[APM] Alerts chart preview wrong timezone #116014

merged 2 commits into from
Oct 25, 2021

Conversation

cauemarcondes
Copy link
Contributor

closes #115958

Screen Shot 2021-10-21 at 3 35 42 PM

Screen Shot 2021-10-21 at 3 36 17 PM

Screen Shot 2021-10-21 at 3 36 45 PM

Screen Shot 2021-10-21 at 4 20 43 PM

@cauemarcondes cauemarcondes added release_note:fix auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 21, 2021
@cauemarcondes cauemarcondes requested review from a team as code owners October 21, 2021 20:30
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Oct 21, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

sorenlouv
sorenlouv approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @cauemarcondes !!

@cauemarcondes cauemarcondes enabled auto-merge (squash) October 21, 2021 21:51
@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1191 1194 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.5MB 2.7MB +155.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 29.3KB 29.3KB +7.0B
data 468.3KB 468.3KB +30.0B
total +37.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 1732927 into elastic:master Oct 25, 2021
@cauemarcondes cauemarcondes deleted the apm-chart-timezone branch October 25, 2021 18:14
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 25, 2021
@cauemarcondes @kibanamachine
adjusting charts timezone (elastic#116014)
2d0d765
@kibanamachine kibanamachine mentioned this pull request Oct 25, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.16

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 25, 2021
@kibanamachine @cauemarcondes
adjusting charts timezone (#116014) (#116193)
5e36c6e 
Co-authored-by: Cauê Marcondes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@lukasolson lukasolson lukasolson approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Alerts chart preview wrong timezone
5 participants
@cauemarcondes @elasticmachine @kibanamachine @sorenlouv @lukasolson