Feature sharelink #1155
Feature sharelink #1155
Conversation
…eliminate looping and put the event in the center of the search.
Don't do any replacements if there are already ARGS references in the dashboard.
Conflicts: src/app/filters/all.js
| module.filter('shareLink', function($location) { | ||
| return function(event) { | ||
| var from = new Date(Date.parse(event._source[this.panel.timeField])-60000); | ||
| var to = new Date(Date.parse(event._source[this.panel.timeField])+60000); |
There was a problem hiding this comment.
Date.parse is generally unreliable for parsing timestamps, this will fail for any data that doesn't use iso8601.
|
This is really very logstash specific and makes a number of assumptions. I understand the benefit of trying to link to the event on the same dashboard, but given the compromises that must be made I really think one of the options we discussed before is a better solution. |
… feature_sharelink Conflicts: src/app/panels/table/module.html
|
Woops! Sorry about that! We recently replaced the master branch with Kibana 4. This action force closed all of the old pull requests against master. We will be reviewing these on a case-by-case basis and creating new tickets as necessary. The good news is that many long requested features can be found in Kibana 4, and we're being entirely open about our roadmap. Check out the roadmap tickets (which we're still filling in) here. If you're looking for the old Kibana 3 code you can find it here. |
|
We're stopping development on Kibana 3 and focusing on Kibana 4 going forward. This can't be merged as-is, but is tagged for completion in Kibana 4 Beta 3 - you can track progress in #717 |
This implements the feature request #717.
Additionally, it adds consistent URL arg support to all dashboards.
This is a re-pull of pull #1100, with a branch rename to facilitate managing multiple pull requests.