[Security Solution][Endpoint] Fix unhandled promise rejections in skipped tests #115354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dasansol92
added
v8.0.0
release_note:skip
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
academo
approved these changes
Oct 18, 2021
dasansol92
requested review from
a team and
paul-tavares
and removed request for
parkiino and
a team
kevinlog
approved these changes
Oct 18, 2021
paul-tavares
approved these changes
Oct 18, 2021
| import { | ||
| EndpointPrivileges, | ||
| useEndpointPrivileges, | ||
| } from '../../../../../../common/components/user_privileges/use_endpoint_privileges'; |
There was a problem hiding this comment.
just FYI - depending on whether my PR goes in first, you might need to adjust this path here and below on line 28
| @@ -42,8 +36,17 @@ let coreStart: AppContextTestRender['coreStart']; | |||
| let http: typeof coreStart.http; | |||
| const generator = new EndpointDocGenerator(); | |||
|
|
|||
| // unhandled promise rejection: https://github.com/elastic/kibana/issues/112699 | |||
| describe.skip('Policy trusted apps layout', () => { | |||
| describe('Policy trusted apps layout', () => { | |||
There was a problem hiding this comment.
FYI: same here. My pending PR has a method that does this same thing called getEndpointPrivilegesInitialStateMock()
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 18, 2021
…pped tests (elastic#115354) * Fix errors and comment code in middleware (pending to fix this) * Fix endpoint list middleware test * Fix policy TA layout test * Fix test returning missing promise
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Oct 19, 2021
…pped tests (#115354) (#115399) * Fix errors and comment code in middleware (pending to fix this) * Fix endpoint list middleware test * Fix policy TA layout test * Fix test returning missing promise Co-authored-by: David Sánchez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes some unhandled promise rejections after upgrade node version and reenable skipped tests.
For maintainers