[Lens] fix focus on legend action popovers

[rshen91]

Summary

Focus is returned to the legend item once closing a popover in Lens and on a dashboard.

This fix is related to elastic/elastic-charts#1266 for issues with focus after closing the popover in visualizations.

AFTER

Oct-14-2021.11-49-27.mp4

BEFORE

Oct-12-2021.10-32-10.mp4

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[rshen91]

@elasticmachine merge upstream

[rshen91]

@elasticmachine merge upstream

[rshen91]

@elasticmachine merge upstream

[rshen91]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: abe3aeb
• Storybooks Preview

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
lens	1.0MB	1.0MB	+182.0B
visTypePie	51.1KB	51.3KB	+182.0B
visTypeXy	61.7KB	61.9KB	+182.0B
total			+546.0B

History

• 💚 Build #162046 succeeded 1f41b4b
• 💚 Build #161595 succeeded 06861b5
• 💚 Build #161483 succeeded 5f86bc2
• 💔 Build #161119 failed c50b9e4
• 💔 Build #161081 failed 540eaf6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[rshen91]

@elasticmachine merge upstream

[rshen91]

Fix changed in elastic/elastic-charts#1423 - waiting for an elastic charts and will update this PR accordingly thanks

[rshen91]

Charts release 38.1.1 includes the accessibility improvements!

[rshen91]

@elasticmachine merge upstream

[kibanamachine]

merge conflict between base and head

[nickofthyme]

@elasticmachine merge upstream

[rshen91]

@elasticmachine merge upstream

[nickofthyme]

@elastic/kibana-vis-editors could we get a CO review here? Thanks! 🙏

[kibanamachine]

💚 Build Succeeded

• Buildkite Build
• Commit: cb3a07f
• Storybooks Preview

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
lens	947.7KB	947.7KB	+46.0B
visTypePie	50.2KB	50.2KB	+46.0B
visTypeXy	59.6KB	59.7KB	+46.0B
total			+138.0B

History

• 💚 Build #4803 succeeded 7cd6bf4
• 💔 Build #4768 failed 32ef603
• 💚 Build #4683 succeeded c02de93
• 💔 Build #3422 failed df23ed1
• 💔 Build #3283 failed a8f8fc2
• 💔 Build #2524 failed 5b3e159

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[mbondyra]

The solution works fine, but there's one more case it gets lost.

1. Create a chart with a legend.
2. Tab to the legend item and open action popover
3. enter on 'filter out value' and confirm
4. The focus comes back to the beginning of the page because the legend items changed.

I think the improvement would be to place the focus before or after the legend, unless there's a better option?

Nov-08-2021.17-15-49.mp4

I'll approve this PR because maybe it's better to take care of the other problem separately.

[kibanamachine]

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 115066 or prevent reminders by adding the backport:skip label.

[elasticmachine]

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)