Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kibanaUtils] Don't import full semver client side #114986

Merged
merged 7 commits into from
Oct 18, 2021
Merged

[kibanaUtils] Don't import full semver client side #114986

merged 7 commits into from
Oct 18, 2021

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Oct 14, 2021 •
edited
Loading

Summary

Part of #114988

semver package is quite large and we can import less code by targeting needed functions.
By adding a eslint rule for public and common code I found other places and changed imports there also

@Dosant Dosant mentioned this pull request Oct 14, 2021
Closed
3 tasks
@Dosant Dosant closed this Oct 14, 2021
@Dosant Dosant deleted the d/2021-10-14-kibana-utils-bundle branch October 14, 2021 13:57
@Dosant Dosant restored the d/2021-10-14-kibana-utils-bundle branch October 14, 2021 13:57
@Dosant Dosant reopened this Oct 14, 2021
@Dosant Dosant changed the title reduce kibana utils bundle [kibanaUtils] Don't import full semver client side Oct 14, 2021
@Dosant Dosant added performance release_note:skip Skip the PR/issue when compiling release notes technical debt Improvement of the software architecture and operational architecture v7.16.0 v8.0.0 Team:AppServicesUx labels Oct 14, 2021
@Dosant Dosant marked this pull request as ready for review October 14, 2021 18:05
@Dosant Dosant requested review from a team as code owners October 14, 2021 18:05
spalger
spalger approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Oct 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

kpollich
kpollich approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet changes LGTM

sabarasaba
sabarasaba approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stack management changes LGTM 🚀 didnt test locally

patrykkopycinski
patrykkopycinski approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asset management LGTM, Thank you!

@Dosant
Copy link
Contributor Author

Dosant commented Oct 15, 2021

@elasticmachine merge upstream

ThomThomson
ThomThomson approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dashboard changes LGTM! Thanks for updating the limits.yml!

ppisljar
ppisljar approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

Dosant added 3 commits October 18, 2021 11:04
@Dosant
Merge branch 'master' of github.com:elastic/kibana into d/2021-10-14-…
55c9885 
…kibana-utils-bundle

# Conflicts:
#	x-pack/plugins/osquery/public/packs/queries/query_flyout.tsx
#	x-pack/plugins/osquery/public/scheduled_query_groups/form/queries_field.tsx
@Dosant
fix merge
45f3bf2
@Dosant
Merge branch 'd/2021-10-14-kibana-utils-bundle' of github.com:Dosant/…
b243569 
…kibana into d/2021-10-14-kibana-utils-bundle
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dashboard 246 219 -27
fleet 586 556 -30
indexManagement 549 511 -38
kibanaUtils 205 168 -37
osquery 266 239 -27
total -159

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 136.0KB 143.1KB +7.1KB
fleet 634.8KB 622.1KB -12.7KB
indexManagement 523.5KB 523.4KB -59.0B
kibanaUtils 52.2KB 52.1KB -37.0B
osquery 873.1KB 866.3KB -6.8KB
total -12.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 182.1KB 168.4KB -13.8KB
indexManagement 50.2KB 36.4KB -13.8KB
kibanaUtils 85.8KB 72.0KB -13.8KB
total -41.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 18, 2021
@Dosant Dosant merged commit c6be6c0 into elastic:master Oct 18, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 114986

@Dosant Dosant mentioned this pull request Oct 18, 2021
Merged
Dosant added a commit to Dosant/kibana that referenced this pull request Oct 18, 2021
@Dosant
[kibanaUtils] Don't import full semver client side (elastic#114986)
e05cd46 
# Conflicts:
#	packages/kbn-optimizer/limits.yml
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 18, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/add…
36426c6 
…-link-to-kibana-app

* 'master' of github.com:elastic/kibana: (287 commits)
  [Security Solution][Endpoint] Change `trustedAppByPolicyEnabled` flag to `true` by default (elastic#115264)
  [APM] generator: support error events and application metrics (elastic#115311)
  [kibanaUtils] Don't import full `semver` client side (elastic#114986)
  [RAC] Link inventory alerts to the right inventory view (elastic#113553)
  [Uptime] Added uptime query inspector panel (elastic#115170)
  [Osquery] Add packs (elastic#107345)
  [App Search] Allow for query parameter to indicate ingestion mechanism for new engines (elastic#115188)
  [Alerting] Active alerts do not recover after re-enabling a rule (elastic#111671)
  skip flaky tests.  elastic#115308, elastic#115313
  [Breaking] Remove deprecated `enabled` settings from plugins. (elastic#113495)
  skip flaky suite.  elastic#107057
  skip flaky tests. elastic#89052, elastic#113418, elastic#115304
  skip flaky test. elastic#113892
  Bump node to 16.11.1 (elastic#110684)
  [Security Solution] Restores Alerts table local storage persistence and the Remove Column action (elastic#114742)
  skip flaky suite.  elastic#115130
  one line remove assert (elastic#115127)
  Fixes migration bug where I was deleting attributes (elastic#115098)
  [Security Solutions] Fixes the newer notification system throttle resets and enabling immediate execution on first detection of a signal  (elastic#114214)
  [build] Dockerfile update (elastic#115237)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
Dosant added a commit that referenced this pull request Oct 18, 2021
@Dosant
[kibanaUtils] Don't import full semver client side (#114986) (#115343)
2999b96 
# Conflicts:
#	packages/kbn-optimizer/limits.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

@ppisljar ppisljar ppisljar approved these changes

@kpollich kpollich kpollich approved these changes

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@spalger spalger spalger approved these changes

@sabarasaba sabarasaba sabarasaba approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed performance release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Dosant @elasticmachine @kibanamachine @sabarasaba @spalger @patrykkopycinski @kpollich @ppisljar @ThomThomson