[ML] Fix deletion of models that are not used by pipelines #114107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
release_note:fix
:ml
v8.0.0
Feature:Data Frame Analytics
|
Pinging @elastic/ml-ui (:ml) |
pheyos
reviewed
Oct 6, 2021
16 tasks
⏳ Build in-progress, with failures
Failed CI StepsHistory
To update your PR or re-run it, just comment with: |
|
Checking test stability in a flaky test runner job ... no failures in 50 runs ✔️ |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
peteharverson
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 7, 2021
…14107) * [ML] Fix deletion of models that are not used by pipelines * [ML] Edits from review * [ML] Fix jest test for index switch in delete job modal * [ML] Fix API test calls to createTestTrainedModels * [ML] Remove unnecessary async from jest test
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Oct 7, 2021
…114355) * [ML] Fix deletion of models that are not used by pipelines * [ML] Edits from review * [ML] Fix jest test for index switch in delete job modal * [ML] Fix API test calls to createTestTrainedModels * [ML] Remove unnecessary async from jest test Co-authored-by: Pete Harverson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #113013 where trained models that weren't in use by a pipeline could not be selected for deletion in the models list in the data frame analytics page as the delete action and selection checkboxes were incorrectly disabled.
This was caused by a regression introduced in #99174, which meant that an empty
pipelinesobject is returned by the/api/ml/trained_models/:modelIdendpoint for models not used by pipelines, where beforenullwas returned.Also adds extra functional tests for the trained models list, which would have caught the original bug, and fixes an error in
use_delete_action.tsxin the return value foruserCanDelete.Checklist
Fixes #113013