Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial forward-port of dacf0c2a6cabf088b0f17f4eca57e01c466286c0. #113672

Merged
merged 3 commits into from
Oct 4, 2021

Conversation

cjcenizal
Copy link
Contributor

Partial forwardport of the changes to ES UI Shared made in #112420:

  • Add Authorization type to ES UI shared.
  • Add convertPrivilegesToArray, patch to also accept privileges that might contain dots in its name, and add tests.

- Add Authorization type to ES UI shared.
- Add convertPrivilegesToArray, patch to also accept privileges that might contain dots in its name, and add tests.
@cjcenizal cjcenizal added enhancement New value added to drive a business result v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v7.16.0 labels Oct 1, 2021
@cjcenizal cjcenizal requested a review from sabarasaba October 1, 2021 20:19
@cjcenizal cjcenizal requested a review from a team as a code owner October 1, 2021 20:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@sabarasaba
Copy link
Member

@elasticmachine merge upstream

@sebelga
Copy link
Contributor

sebelga commented Oct 4, 2021

Great to see this PR. Thanks @cjcenizal ! We should really strive to not have different code base between 7.x and 8.x. Specially with any reusable piece of code.
The reasoning is that it is extremely difficult to remember all the little nuances between the branches, if any new dev joins the team he won't know them, backport could potentially break (and we need to know the nuances to correctly fix them to avoid regressions). It is true that 7.16.x should receive little patches (hopefully) but I think it is good to have a common approach and stick to it. Be it for a single minor to support (like now) or the full range of minors coming in 8.x.

@cjcenizal
Copy link
Contributor Author

We should really strive to not have different code base between 7.x and 8.x.

👍 Yep, that's why this is being forward-ported. We missed it originally.

@cjcenizal
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
esUiShared 102 106 +4

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
esUiShared 1 3 +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
esUiShared 124.5KB 124.5KB +83.0B
Unknown metric groups

API count

id before after diff
esUiShared 106 110 +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cjcenizal cjcenizal merged commit 257e33a into elastic:master Oct 4, 2021
@cjcenizal cjcenizal deleted the forwardport/8.0/112420 branch October 4, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants