Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci-stats] Local metrics fixes #113492

Merged
merged 6 commits into from
Oct 3, 2021
Merged

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Sep 29, 2021

  • Rename { group: 'yarn start', id: 'started' } to { group: 'scripts/kibana', id: 'dev server started' } for consistency
  • Rename { group: '@kbn/optimizer' } to { group: 'scripts/build_kibana_platform_plugins' } for consistency
  • Include email for Elastic employees
  • Standardize on Unix paths
  • Set subProcess: true if the timing is already captured by a parent.

@tylersmalley tylersmalley force-pushed the ci-stats-fixes branch 3 times, most recently from 4549c11 to ef954f3 Compare September 30, 2021 19:37
@tylersmalley tylersmalley changed the title [ci-stats] Minor fixes [ci-stats] Local metrics fixes Sep 30, 2021
@tylersmalley tylersmalley added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.16.0 v8.0.0 labels Sep 30, 2021
@tylersmalley tylersmalley marked this pull request as ready for review September 30, 2021 19:53
@tylersmalley tylersmalley requested a review from a team as a code owner September 30, 2021 19:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley tylersmalley enabled auto-merge (squash) September 30, 2021 22:29
kibanaUuid,
nestedTiming: process.env.CI_STATS_NESTED_TIMING,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We support booleans in metadata, we should use one here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elastic elastic deleted a comment from kibanamachine Oct 1, 2021
Tyler Smalley added 2 commits September 30, 2021 18:13
* Rename `{ group: 'yarn start', id: 'started' }` to `{ group: 'scripts/kibana', id: 'dev server started' }` for consistency
* Rename `{ group: '@kbn/optimizer' }` to `{ group: 'scripts/build_kibana_platform_plugins' }` for consistency
* Include email for Elastic employees
* Standardize on Unix paths
* Set `subProcess: true` if the timing is already captured by a parent.

Signed-off-by: Tyler Smalley <[email protected]>
Tyler Smalley added 2 commits September 30, 2021 22:48
Signed-off-by: Tyler Smalley <[email protected]>
Signed-off-by: Tyler Smalley <[email protected]>
@tylersmalley
Copy link
Contributor Author

@spalger this is ready for another pass.

@tylersmalley
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs

@tylersmalley tylersmalley merged commit 284732f into elastic:master Oct 3, 2021
@tylersmalley tylersmalley added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 3, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 3, 2021
* Rename `{ group: 'yarn start', id: 'started' }` to `{ group: 'scripts/kibana', id: 'dev server started' }` for consistency
* Rename `{ group: '@kbn/optimizer' }` to `{ group: 'scripts/build_kibana_platform_plugins' }` for consistency
* Include email for Elastic employees
* Standardize on Unix paths
* Set `subProcess: true` if the timing is already captured by a parent.
* Move nestedTiming to global and use normalize-path
kibanamachine added a commit that referenced this pull request Oct 3, 2021
* Rename `{ group: 'yarn start', id: 'started' }` to `{ group: 'scripts/kibana', id: 'dev server started' }` for consistency
* Rename `{ group: '@kbn/optimizer' }` to `{ group: 'scripts/build_kibana_platform_plugins' }` for consistency
* Include email for Elastic employees
* Standardize on Unix paths
* Set `subProcess: true` if the timing is already captured by a parent.
* Move nestedTiming to global and use normalize-path

Co-authored-by: Tyler Smalley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants