Fixes error with percentiles on index with many docs #113216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
changed the title
stratoula
added
v7.15.1
v7.16.0
v8.0.0
release_note:fix
Team:AppServicesSv
Team:Visualizations
|
Pinging @elastic/kibana-vis-editors (Team:VisEditors) |
|
Yes maybe we should inform the ES team about it. I assume that it comes from ES, not 100% sure. I tried to find a kibana change that maybe initiated it but I couldn't find anything. @ppisljar @flash1293 wdyt? |
stratoula
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 29, 2021
* Fixes error with metric viz and percentiles on index with many docs * Unskip the metric viz suite * Adds a unit test
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 29, 2021
* Fixes error with metric viz and percentiles on index with many docs * Unskip the metric viz suite * Adds a unit test
kibanamachine
added a commit
that referenced
this pull request
Sep 29, 2021
* Fixes error with metric viz and percentiles on index with many docs * Unskip the metric viz suite * Adds a unit test Co-authored-by: Stratoula Kalafateli <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Sep 29, 2021
* Fixes error with metric viz and percentiles on index with many docs * Unskip the metric viz suite * Adds a unit test Co-authored-by: Stratoula Kalafateli <[email protected]>
This was referenced Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #106121
closes #113215
This fixes the error described on the issue. Specifically, we found out that when we are using percentiles agg on visualizations based on an index with many documents, the request returns zero data. As a result, the destructure fails and the error appears.
By providing a fallback, seems to solve the problem.
Runner 100 times https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1949/
Runner 100 times https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1950/