Get rid of saved object loader

[flash1293]

tbd

[flash1293]

@VladLasitsa this stuff is only necessary for the legacy import - we need to create a valid saved vis instance which captures the error state. As this won't be used for legacy import, we can just bubble up the error.

[flash1293]

This is probably true for a bunch more places, but I think some of that cruft is not necessary anymore.

[VladLasitsa]

@elasticmachine merge upstream

[kibanamachine]

user doesn't have permission to update head repository

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 7af8213
• Storybooks Preview

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
visualizations	107	108	+1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
savedObjectsTaggingOss	51	56	+5
visualizations	257	297	+40
total			+45

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id	before	after	diff
savedObjectsTaggingOss	3	5	+2
visualizations	13	15	+2
total			+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
visualizations	72.0KB	72.0KB	-9.0B
visualize	51.7KB	53.2KB	+1.5KB
total			+1.5KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
savedObjectsTaggingOss	0	1	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
savedObjectsTaggingOss	3.7KB	3.8KB	+51.0B
visualizations	32.9KB	38.8KB	+5.9KB
visualize	15.9KB	15.9KB	+16.0B
total			+6.0KB

Unknown metric groups

API count

id	before	after	diff
savedObjectsTaggingOss	90	95	+5
visualizations	275	315	+40
total			+45

References to deprecated APIs

id	before	after	diff
visualizations	89	87	-2

History

• 💔 Build #155570 failed 58f3c58
• 💔 Build #155559 failed ab285e1
• 💔 Build #155347 failed cda436d
• 💔 Build #155318 failed 7cd5973
• 💔 Build #154616 failed 1560e50

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[VladLasitsa]

Closed because will opene new PR myself: #113121