Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Endpoint] Unit test for the ArtifactEntryCard #111995

Conversation

paul-tavares
Copy link
Contributor

Summary

  • Add UT for the ArtifactEntryCard
  • Added logic to the ArtifactEntryCard to derive the EffectScope from the tags array (similar to what is done in Trusted Apps)

@paul-tavares paul-tavares added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Sep 13, 2021
@paul-tavares paul-tavares self-assigned this Sep 13, 2021
@paul-tavares paul-tavares requested a review from a team as a code owner September 13, 2021 17:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@paul-tavares paul-tavares requested review from dasansol92 and removed request for joeypoon September 13, 2021 17:09
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2401 2402 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.5MB 6.5MB +348.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @paul-tavares

Copy link
Contributor

@dasansol92 dasansol92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@paul-tavares paul-tavares merged commit eeca809 into elastic:master Sep 14, 2021
@paul-tavares paul-tavares deleted the task/olm-695-artifact-entry-card-unit-tests branch September 14, 2021 15:58
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 14, 2021
…lastic#111995)

* Test file for ArtifactEntryCard
* Fix i18n pluralization
* refactor mapper of trusted apps for tags-to-effectScope from server code to common
* determine EffectScope for Exceptions based on tags
* Fix margin on artifact card divider
* Updated snapshot
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 14, 2021
…111995) (#112137)

* Test file for ArtifactEntryCard
* Fix i18n pluralization
* refactor mapper of trusted apps for tags-to-effectScope from server code to common
* determine EffectScope for Exceptions based on tags
* Fix margin on artifact card divider
* Updated snapshot

Co-authored-by: Paul Tavares <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants