Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAC][Metrics UI] Link inventory threshold alerts to a specific timestamp in the metrics app #111380

Closed

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Sep 7, 2021

Summary

Closes #106497

I've added a new /metrics/link-to handler to allow linking to a specific timestamp in the inventory app, and used it in the alert formatter to link to the @timestamp. The link generation is naive. I appreciate if someone from the metrics part of @elastic/logs-metrics-ui could give me pointers on how to generate that link.

I've made the assumption that the user will be interested in the point in time where the alert has changed. For example if the alert is resolved, we link to the resolution timestamp. If this assumption is incorrect please let me know.

@afgomez afgomez added Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed Feature:RAC label obsolete v7.15.0 v7.16.0 Feature:Observability RAC labels Sep 7, 2021
@afgomez afgomez requested a review from a team as a code owner September 7, 2021 13:17
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 971 972 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.7MB 1.7MB +1.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 150.4KB 150.4KB +56.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez afgomez marked this pull request as draft September 9, 2021 15:53
@afgomez
Copy link
Contributor Author

afgomez commented Oct 5, 2021

Superseeded by #113553

@afgomez afgomez closed this Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Metrics UI Metrics UI feature Feature:Observability RAC Feature:RAC label obsolete release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RAC][Metrics UI] Link to an inventory item with the flyout open at a certain point in time
2 participants