Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add Fleet diagrams to dev_docs #110794

Merged
merged 2 commits into from
Sep 1, 2021

Conversation

kpollich
Copy link
Member

@kpollich kpollich commented Sep 1, 2021

Summary

Adds some initial diagrams to Fleet's dev_docs folder in an effort to improve onboarding and documentation.

@kpollich kpollich added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Sep 1, 2021
@kpollich kpollich self-assigned this Sep 1, 2021
@kpollich kpollich requested a review from a team as a code owner September 1, 2021 12:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kpollich
Copy link
Member Author

kpollich commented Sep 1, 2021

Do docs PR's like this need an iteration label like v7.16.0 v8.0.0 etc?

@nchaulet
Copy link
Member

nchaulet commented Sep 1, 2021

I think in the architecture overview this arrow will be more accurate if its between elasticsearch and fleet server as there is no connection between Kibana and Fleet server

Screen Shot 2021-09-01 at 9 19 25 AM

@nchaulet
Copy link
Member

nchaulet commented Sep 1, 2021

Do docs PR's like this need an iteration label like v7.16.0 v8.0.0 etc?

Yes it make sense to have this backported in 7.x

@kpollich
Copy link
Member Author

kpollich commented Sep 1, 2021

I think in the architecture overview this arrow will be more accurate if its between elasticsearch and fleet server as there is no connection between Kibana and Fleet server

Good call 👍 - Addressed in 9991770

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kpollich kpollich enabled auto-merge (squash) September 1, 2021 14:04
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@kpollich kpollich merged commit 3662a39 into elastic:master Sep 1, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 1, 2021
* Add initial fleet dev diagrams to dev_docs

* Move Fleet Server arrow to ES instead of Kibana
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 1, 2021
* Add initial fleet dev diagrams to dev_docs

* Move Fleet Server arrow to ES instead of Kibana

Co-authored-by: Kyle Pollich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants