-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Archive Migration][Partial] discover apps-home #110440
[Archive Migration][Partial] discover apps-home #110440
Conversation
No need to include a mention for me in the description. It results in me getting a notification for every update to this PR. If you need a review, or have a question - then feel free to include a mention. Thanks. |
c0914a8
to
07fdafb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but if you wouldn't mind adding the one additional cleanup step.
}); | ||
|
||
after(async () => { | ||
await kibanaServer.importExport.unload('test/functional/fixtures/kbn_archiver/discover'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor request to also add this here. I'm sure we don't do it everywhere but since there's a call to .replace({ defaultIndex: 'logstash-*' });
it's probably best to clear it out too;
await kibanaServer.uiSettings.replace({});
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but now I'm also wondering if unloading the kbn_archive unloads the config saved object? That's where the default index pattern is saved. You could check by looking in Advanced Settings after this test runs and see if it's set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so I've been having issues starting the ftr server, for the last few days.
That said, I was able to use the saved objects info cli call.
After dropping out most of the test, and leaving the before and after calls in place (I also added the ui settings replace you asked for above), I got this:
node scripts/saved_objs_info.js --esUrl http://elastic:changeme@localhost:9220 --soTypes
succ
### Saved Object Types Count: 6
[
{
doc_count: 5,
key: 'canvas-workpad-template'
},
{
doc_count: 1,
key: 'apm-telemetry'
},
{
doc_count: 1,
key: 'config'
},
{
doc_count: 1,
key: 'core-usage-stats'
},
{
doc_count: 1,
key: 'event_loop_delays_daily'
},
{
doc_count: 1,
key: 'space'
}
]
So, the config count so type count, is 1.
I think that means we are good. Your thoughts sir? @LeeDr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, in case you were wondering, when I run the call just after staring the ftr server, I get this:
node scripts/saved_objs_info.js --esUrl http://elastic:changeme@localhost:9220 --soTypes
succ
### Saved Object Types Count: 4
[
{
doc_count: 5,
key: 'canvas-workpad-template'
},
{
doc_count: 1,
key: 'apm-telemetry'
},
{
doc_count: 1,
key: 'config'
},
{
doc_count: 1,
key: 'space'
}
]
07fdafb
to
aec11c9
Compare
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Co-authored-by: Tre <[email protected]>
Comes from #102827
Helps with #108503
Unload the shakespeare data in the previous suite,
and replace the ui settings with an empty object literal,
so to prepare the home suite to run from a clean state.
Additionally, set the default index to
logstash-*
inthe home suite.
Only include the changes under the
test/functional/apps/home folder.