Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snapshotsUrl to Cloud plugin public interface. #110328

Merged
merged 5 commits into from
Sep 1, 2021
Merged

Add snapshotsUrl to Cloud plugin public interface. #110328

merged 5 commits into from
Sep 1, 2021

Conversation

cjcenizal
Copy link
Contributor

Fixes #110311

@cjcenizal cjcenizal added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Aug 26, 2021
@cjcenizal cjcenizal requested a review from pgayvallet August 26, 2021 19:31
@cjcenizal cjcenizal requested a review from a team as a code owner August 26, 2021 19:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@cjcenizal cjcenizal force-pushed the cloud/snapshots-url branch from 3ce6c30 to 63815a0 Compare August 26, 2021 19:33
@cjcenizal
Copy link
Contributor Author

@elasticmachine merge upstream

@cjcenizal
Copy link
Contributor Author

@elasticmachine merge upstream

@cjcenizal
Copy link
Contributor Author

@elasticmachine merge upstream

TinaHeiligers
TinaHeiligers reviewed Sep 1, 2021
View reviewed changes
x-pack/plugins/cloud/public/plugin.ts
@@ -54,6 +54,7 @@ export interface CloudSetup {
deploymentUrl?: string;
profileUrl?: string;
organizationUrl?: string;
snapshotsUrl?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: We've made a change to the setup contract and need to update the cloud plugin tests too.
Considering that we want to track consumption of the url, we should at the very least have a test in place to make sure it is there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Will do.

TinaHeiligers
TinaHeiligers approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentatively approving since the change is small but I really would like to have a test for something that we want to track.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
cloud 21 22 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloud 9.3KB 9.4KB +115.0B
Unknown metric groups

API count

id before after diff
cloud 21 22 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cjcenizal cjcenizal merged commit cf8ab3b into elastic:master Sep 1, 2021
@cjcenizal cjcenizal deleted the cloud/snapshots-url branch September 1, 2021 21:42
@cjcenizal cjcenizal mentioned this pull request Sep 1, 2021
Merged
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Sep 1, 2021
@cjcenizal
Add snapshotsUrl to Cloud plugin public interface. (elastic#110328)
7b01335 
* Add unit tests for Cloud plugin setup interface.
cjcenizal added a commit that referenced this pull request Sep 2, 2021
@cjcenizal
Add snapshotsUrl to Cloud plugin public interface. (#110328) (#110915)
0824bd8 
* Add unit tests for Cloud plugin setup interface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees
No one assigned
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add snapshots URL to Cloud plugin
5 participants
@cjcenizal @elasticmachine @kibanamachine @pgayvallet @TinaHeiligers