[Canvas] Fixes Storybook for DatasourceComponent is crashing. #110180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuznietsov
added
release_note:fix
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
crob611
approved these changes
Aug 27, 2021
| @@ -20,7 +20,7 @@ import { | |||
| import { isEqual } from 'lodash'; | |||
| import { i18n } from '@kbn/i18n'; | |||
|
|
|||
| import { getDefaultIndex } from '../../lib/es_service'; | |||
| import { getDefaultIndex } from '../../../public/lib/es_service'; | |||
There was a problem hiding this comment.
Is there a reason this import had to change? Please leave it as it was if not necessary to change
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @Kunzetsov |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 27, 2021
…c#110180) * Added mock for `es_service`. Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Aug 27, 2021
… (#110397) * Added mock for `es_service`. Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Yaroslav Kuznietsov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #105190.
Added
mockfores_serviceto prevent calling not existing function.Before:
After: