Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CrawlerLanding page #109712

Merged
merged 2 commits into from
Aug 24, 2021

Conversation

JasonStoltz
Copy link
Member

@JasonStoltz JasonStoltz commented Aug 23, 2021

Summary

The CrawlerLanding page was being shown in non-development versions.
Now that we are at 7.15, CrawlerOverview should be shown all of the
time instead.

Checklist

For maintainers

The CrawlerLanding page was being shown in non-development versions.
Now that we are at 7.15, CrawlerOverview should be shown all of the
time instead.
@JasonStoltz JasonStoltz requested a review from a team August 23, 2021 18:12
@JasonStoltz JasonStoltz requested a review from a team as a code owner August 23, 2021 18:12
@JasonStoltz JasonStoltz added auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.16.0 release_note:skip Skip the PR/issue when compiling release notes labels Aug 23, 2021
Copy link
Contributor

@orhantoy orhantoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JasonStoltz Looks like some translations need to be deleted.

Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving SCSS change; file removed.

@byronhulcher byronhulcher enabled auto-merge (squash) August 24, 2021 00:11
@byronhulcher
Copy link
Contributor

byronhulcher commented Aug 24, 2021

Sorry about this everyone (especially to @orhantoy who suggested I use a feature flag for this like six months ago)

Also for future reference I used node scripts/i18n_check --fix and that fixed all the i18n stuff for me. I didn't have to touch the json files.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 1484 1472 -12

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.1MB 2.2MB +12.8KB
Unknown metric groups

miscellaneous assets size

id before after diff
enterpriseSearch 1.0MB 1015.5KB -14.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @byronhulcher

@byronhulcher byronhulcher merged commit d9e0b98 into elastic:master Aug 24, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 24, 2021
* Remove CrawlerLanding page

The CrawlerLanding page was being shown in non-development versions.
Now that we are at 7.15, CrawlerOverview should be shown all of the
time instead.

* Remove translations from ja-JP and zh-CN

Co-authored-by: Byron Hulcher <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 24, 2021
* Remove CrawlerLanding page

The CrawlerLanding page was being shown in non-development versions.
Now that we are at 7.15, CrawlerOverview should be shown all of the
time instead.

* Remove translations from ja-JP and zh-CN

Co-authored-by: Byron Hulcher <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.15
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 24, 2021
* Remove CrawlerLanding page

The CrawlerLanding page was being shown in non-development versions.
Now that we are at 7.15, CrawlerOverview should be shown all of the
time instead.

* Remove translations from ja-JP and zh-CN

Co-authored-by: Byron Hulcher <[email protected]>

Co-authored-by: Jason Stoltzfus <[email protected]>
Co-authored-by: Byron Hulcher <[email protected]>
kibanamachine added a commit that referenced this pull request Aug 24, 2021
* Remove CrawlerLanding page

The CrawlerLanding page was being shown in non-development versions.
Now that we are at 7.15, CrawlerOverview should be shown all of the
time instead.

* Remove translations from ja-JP and zh-CN

Co-authored-by: Byron Hulcher <[email protected]>

Co-authored-by: Jason Stoltzfus <[email protected]>
Co-authored-by: Byron Hulcher <[email protected]>
@JasonStoltz
Copy link
Member Author

Thanks ya'll! Thanks for the tip on that script also @byronhulcher.

@JasonStoltz JasonStoltz deleted the remove-crawler-landing branch August 24, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants