-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CrawlerLanding page #109712
Remove CrawlerLanding page #109712
Conversation
The CrawlerLanding page was being shown in non-development versions. Now that we are at 7.15, CrawlerOverview should be shown all of the time instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JasonStoltz Looks like some translations need to be deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving SCSS change; file removed.
Sorry about this everyone (especially to @orhantoy who suggested I use a feature flag for this like six months ago) Also for future reference I used |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Unknown metric groupsmiscellaneous assets size
History
To update your PR or re-run it, just comment with: |
* Remove CrawlerLanding page The CrawlerLanding page was being shown in non-development versions. Now that we are at 7.15, CrawlerOverview should be shown all of the time instead. * Remove translations from ja-JP and zh-CN Co-authored-by: Byron Hulcher <[email protected]>
* Remove CrawlerLanding page The CrawlerLanding page was being shown in non-development versions. Now that we are at 7.15, CrawlerOverview should be shown all of the time instead. * Remove translations from ja-JP and zh-CN Co-authored-by: Byron Hulcher <[email protected]>
* Remove CrawlerLanding page The CrawlerLanding page was being shown in non-development versions. Now that we are at 7.15, CrawlerOverview should be shown all of the time instead. * Remove translations from ja-JP and zh-CN Co-authored-by: Byron Hulcher <[email protected]> Co-authored-by: Jason Stoltzfus <[email protected]> Co-authored-by: Byron Hulcher <[email protected]>
* Remove CrawlerLanding page The CrawlerLanding page was being shown in non-development versions. Now that we are at 7.15, CrawlerOverview should be shown all of the time instead. * Remove translations from ja-JP and zh-CN Co-authored-by: Byron Hulcher <[email protected]> Co-authored-by: Jason Stoltzfus <[email protected]> Co-authored-by: Byron Hulcher <[email protected]>
Thanks ya'll! Thanks for the tip on that script also @byronhulcher. |
Summary
The CrawlerLanding page was being shown in non-development versions.
Now that we are at 7.15, CrawlerOverview should be shown all of the
time instead.
Checklist
For maintainers